Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Side by Side Diff: Tools/GardeningServer/model/ct-failure.html

Issue 498523002: [Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase + no sort Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <!-- 1 <!--
2 Copyright 2014 The Chromium Authors. All rights reserved. 2 Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 6
7 <script> 7 <script>
8 function CTFailure(step, reason, resultsByBuilder, firstFailingRevisions, lastPa ssingRevisions) { 8 function CTFailure(step, reason, resultsByBuilder) {
9 this.step = step; 9 this.step = step;
10 // FIXME: Rename this to reason. 10 // FIXME: Rename this to reason.
11 this.testName = reason; 11 this.testName = reason;
12 this.resultNodesByBuilder = resultsByBuilder; 12 this.resultNodesByBuilder = resultsByBuilder;
13 // FIXME: Move these up one layer to the groupedFailures object.
14 this.firstFailingRevisions = firstFailingRevisions;
15 this.lastPassingRevisions = lastPassingRevisions;
16 } 13 }
17 14
18 CTFailure.prototype.flakinessDashboardURL = function(tree) { 15 CTFailure.prototype.flakinessDashboardURL = function(tree) {
19 var testType = this.step; 16 var testType = this.step;
20 17
21 // FIXME: Replace the flakiness dashboard's sense of groups with sheriff-o-mat ic's 18 // FIXME: Replace the flakiness dashboard's sense of groups with sheriff-o-mat ic's
22 // sense of trees and get rid of this mapping. 19 // sense of trees and get rid of this mapping.
23 var treeToDashboardGroup = { 20 var treeToDashboardGroup = {
24 blink: '@ToT%20Blink', 21 blink: '@ToT%20Blink',
25 chromium: '@ToT%20Chromium', 22 chromium: '@ToT%20Chromium',
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 63
67 // FIXME: This should just be provided as part of the alerts feed. 64 // FIXME: This should just be provided as part of the alerts feed.
68 CTFailure.createKey = function(alert) { 65 CTFailure.createKey = function(alert) {
69 function normalize(str) { 66 function normalize(str) {
70 str = str == null ? '' : String(str); 67 str = str == null ? '' : String(str);
71 return str.replace(/:/g, '_'); 68 return str.replace(/:/g, '_');
72 } 69 }
73 return [alert.master_url, alert.builder_name, alert.failing_build, alert.step_ name, alert.reason].map(normalize).join('::'); 70 return [alert.master_url, alert.builder_name, alert.failing_build, alert.step_ name, alert.reason].map(normalize).join('::');
74 } 71 }
75 </script> 72 </script>
OLDNEW
« no previous file with comments | « Tools/GardeningServer/model/ct-commit-log-mock.html ('k') | Tools/GardeningServer/model/ct-failure-group.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698