[Sheriff-o-matic] Use likely_revisions instead of first_failing/last_passing

Tools/GardeningServer/model/ct-commit-log.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="../lib/net.html">
 <link rel='import' href='ct-commit.html'>
 <link rel='import' href='ct-repositories.html'>
 
 <script>
 function CTCommitLog() {
   this.commits = {};
-  this.firstRevision = {};
   this.lastRevision = {};
   this._repositories = new CTRepositories();
 
   this._repositories.names.forEach(function(name) {
     this.commits[name] = {};
   }.bind(this));
 }
 
 CTCommitLog.prototype.update = function() {
   var requests = [];
@@ skipping 18 matching lines @@
     // data-binding properly updates all the <ct-commit>'s.
     var existingCommit = this.commits[repository][revision];
     if (existingCommit && !existingCommit.isComplete) {
       existingCommit.complete(author, message, revision);
     } else {
       var commit = CTCommit.create(author, message, repositoryUrl, repository);
       this.commits[repository][commit.revision] = commit;
     }
   }.bind(this));
 
-  this._findFirstAndLastRevisions(repository);
+  this._updateLastRevision(repository);
 }
 
-CTCommitLog.prototype._findFirstAndLastRevisions = function(repository) {
+CTCommitLog.prototype._updateLastRevision = function(repository) {
   var sortedCommits = Object.keys(this.commits[repository]).sort();
-  this.firstRevision[repository] = parseInt(sortedCommits.first());
-  this.lastRevision[repository] = parseInt(sortedCommits.last());
+  this.lastRevision[repository] = sortedCommits.last();
 }
 
-CTCommitLog.prototype.range = function(repository, first, last) {
+CTCommitLog.prototype.range = function(repository, revisions) {
   var commits = [];
-  for (var revision = first; revision <= last; revision++) {
-     var commit = this.commits[repository][revision];
-     if (!commit) {
-       // FIXME: This is wrong. If we iterate through revisions and then later
-       // in handleReponse we realize that this revision doesn't actually exist
-       // in the repo (e.g. because it corresponds to a branch commit), then we
-       // don't remove the incomplete commit.
-       var url = this._repositories.repositories[repository].repositoryUrl;
-       commit = CTCommit.createIncomplete(url, revision, repository);
-       this.commits[repository][revision] = commit;
-     }
+  revisions.forEach(function(revision) {
+    var commit = this.commits[repository][revision];
+    if (!commit) {
+      var url = this._repositories.repositories[repository].repositoryUrl;
+      var commit = CTCommit.createIncomplete(url, revision, repository);
+      this.commits[repository][revision] = commit;
+    }
 
-     if (commit)
-       commits.push(commit);
-  }
+    if (commit)
+      commits.push(commit);
+  }.bind(this));
   return commits;
 }
 </script>