Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3778)

Unified Diff: chrome/browser/renderer_host/chrome_extension_message_filter.cc

Issue 498513002: Respect the clipboardRead and clipboardWrite permissions in content scripts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address more comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/chrome_extension_message_filter.cc
diff --git a/chrome/browser/renderer_host/chrome_extension_message_filter.cc b/chrome/browser/renderer_host/chrome_extension_message_filter.cc
index ae531912c1f34d9101b88bf3c562156c0d3c2a63..69f919c3e283504efa9616666a3b9c7aba0e09d4 100644
--- a/chrome/browser/renderer_host/chrome_extension_message_filter.cc
+++ b/chrome/browser/renderer_host/chrome_extension_message_filter.cc
@@ -23,13 +23,11 @@
#include "content/public/browser/render_process_host.h"
#include "extensions/browser/extension_system.h"
#include "extensions/common/api/messaging/message.h"
-#include "extensions/common/constants.h"
#include "extensions/common/extension_messages.h"
#include "extensions/common/file_util.h"
#include "extensions/common/message_bundle.h"
using content::BrowserThread;
-using extensions::APIPermission;
namespace {
@@ -88,10 +86,6 @@ bool ChromeExtensionMessageFilter::OnMessageReceived(
const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(ChromeExtensionMessageFilter, message)
- IPC_MESSAGE_HANDLER(ChromeViewHostMsg_CanTriggerClipboardRead,
- OnCanTriggerClipboardRead)
- IPC_MESSAGE_HANDLER(ChromeViewHostMsg_CanTriggerClipboardWrite,
- OnCanTriggerClipboardWrite)
IPC_MESSAGE_HANDLER(ExtensionHostMsg_OpenChannelToExtension,
OnOpenChannelToExtension)
IPC_MESSAGE_HANDLER(ExtensionHostMsg_OpenChannelToTab, OnOpenChannelToTab)
@@ -133,21 +127,6 @@ void ChromeExtensionMessageFilter::OnDestruct() const {
}
}
-void ChromeExtensionMessageFilter::OnCanTriggerClipboardRead(
- const GURL& origin, bool* allowed) {
- *allowed = extension_info_map_->SecurityOriginHasAPIPermission(
- origin, render_process_id_, APIPermission::kClipboardRead);
-}
-
-void ChromeExtensionMessageFilter::OnCanTriggerClipboardWrite(
- const GURL& origin, bool* allowed) {
- // Since all extensions could historically write to the clipboard, preserve it
- // for compatibility.
- *allowed = (origin.SchemeIs(extensions::kExtensionScheme) ||
- extension_info_map_->SecurityOriginHasAPIPermission(
- origin, render_process_id_, APIPermission::kClipboardWrite));
-}
-
void ChromeExtensionMessageFilter::OnOpenChannelToExtension(
int routing_id,
const ExtensionMsg_ExternalConnectionInfo& info,
« no previous file with comments | « chrome/browser/renderer_host/chrome_extension_message_filter.h ('k') | chrome/common/extensions/chrome_extension_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698