Respect the clipboardRead and clipboardWrite permissions in content scripts.

extensions/renderer/script_context.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_
 #define EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 17 matching lines @@
 
 namespace extensions {
 class Extension;
 
 // Extensions wrapper for a v8 context.
 class ScriptContext : public RequestSender::Source, public gin::Runner {
  public:
   ScriptContext(const v8::Handle<v8::Context>& context,
                 blink::WebFrame* frame,
                 const Extension* extension,
-                Feature::Context context_type);
+                Feature::Context context_type,
+                const Extension* effective_extension,
+                Feature::Context effective_context_type);
   virtual ~ScriptContext();
 
   // Clears the WebFrame for this contexts and invalidates the associated
   // ModuleSystem.
   void Invalidate();
 
   // Returns true if this context is still valid, false if it isn't.
   // A context becomes invalid via Invalidate().
   bool is_valid() const { return !v8_context_.IsEmpty(); }
 
   v8::Handle<v8::Context> v8_context() const {
     return v8_context_.NewHandle(isolate());
   }
 
   const Extension* extension() const { return extension_.get(); }
 
+  const Extension* effective_extension() const {
+    return effective_extension_.get();
+  }
+
   blink::WebFrame* web_frame() const { return web_frame_; }
 
   Feature::Context context_type() const { return context_type_; }
 
+  Feature::Context effective_context_type() const {
+    return effective_context_type_;
+  }
+
   void set_module_system(scoped_ptr<ModuleSystem> module_system) {
     module_system_ = module_system.Pass();
   }
 
   ModuleSystem* module_system() { return module_system_.get(); }
 
   SafeBuiltins* safe_builtins() { return &safe_builtins_; }
 
   const SafeBuiltins* safe_builtins() const { return &safe_builtins_; }
 
   // Returns the ID of the extension associated with this context, or empty
   // string if there is no such extension.
   const std::string& GetExtensionID() const;
 
+  // Returns the ID of the effective extension associated with this context, or
+  // empty string if there is no such extension.

[Devlin, 2014/09/03 22:09:16]

Are all  of these accessors really needed?  If not, I'd be in favor of taking
out the ones like this (where it's perfectly easy to instead use
effective_extension()->id()).

[Marijn Kruisselbrink, 2014/09/03 23:54:07]

Well, it's the "or empty string" part that makes it not quite that easy. It's
replacement would be |effective_extension() ? effective_extension()->id() : ""|
or something similar. But either way this is only used in debug logs, so other
than consistency there really isn't a reason to add this accessor. I removed it
(and added a helper method to get the ID for a possibly null extension to an
anonymous namespace).

+  const std::string& GetEffectiveExtensionID() const;
+
   // Returns the RenderView associated with this context. Can return NULL if the
   // context is in the process of being destroyed.
   content::RenderView* GetRenderView() const;
 
   // Returns the RenderFrame associated with this context. Can return NULL if
   // the context is in the process of being destroyed.
   content::RenderFrame* GetRenderFrame() const;
 
   // Runs |function| with appropriate scopes. Doesn't catch exceptions, callers
   // must do that if they want.
   //
   // USE THIS METHOD RATHER THAN v8::Function::Call WHEREVER POSSIBLE.
   v8::Local<v8::Value> CallFunction(v8::Handle<v8::Function> function,
                                     int argc,
                                     v8::Handle<v8::Value> argv[]) const;
 
   void DispatchEvent(const char* event_name, v8::Handle<v8::Array> args) const;
 
   // Fires the onunload event on the unload_event module.
   void DispatchOnUnloadEvent();
 
   // Returns the availability of the API |api_name|.
   Feature::Availability GetAvailability(const std::string& api_name);
 
   // Returns a string description of the type of context this is.

[Devlin, 2014/09/03 22:09:16]

nit: "...of the |context_type|."

[Marijn Kruisselbrink, 2014/09/03 23:54:07]

Acknowledged.

+  static std::string GetContextTypeDescription(Feature::Context context_type);
+
+  // Returns a string description of the type of context this is.
   std::string GetContextTypeDescription();
 
+  // Returns a string description of the type of context this is.

[Devlin, 2014/09/03 22:09:16]

... of the effective type of context...

[Marijn Kruisselbrink, 2014/09/03 23:54:07]

Done.

+  std::string GetEffectiveContextTypeDescription();
+
   v8::Isolate* isolate() const { return isolate_; }
 
   // Get the URL of this context's web frame.
   GURL GetURL() const;
 
   // Returns whether the API |api| or any part of the API could be
   // available in this context without taking into account the context's
   // extension.
   bool IsAnyFeatureAvailableToContext(const extensions::Feature& api);
 
@@ skipping 35 matching lines @@
   // object can outlive is destroyed asynchronously.
   blink::WebFrame* web_frame_;
 
   // The extension associated with this context, or NULL if there is none. This
   // might be a hosted app in the case that this context is hosting a web URL.
   scoped_refptr<const Extension> extension_;
 
   // The type of context.
   Feature::Context context_type_;
 
+  // The effective extension associated with this context, or NULL if there is
+  // none. This is different from the above extension if this context is in an
+  // about:blank iframe for example.
+  scoped_refptr<const Extension> effective_extension_;
+
+  // The type of context.
+  Feature::Context effective_context_type_;
+
   // Owns and structures the JS that is injected to set up extension bindings.
   scoped_ptr<ModuleSystem> module_system_;
 
   // Contains safe copies of builtin objects like Function.prototype.
   SafeBuiltins safe_builtins_;
 
   v8::Isolate* isolate_;
 
   DISALLOW_COPY_AND_ASSIGN(ScriptContext);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_SCRIPT_CONTEXT_H_