Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 498503003: Ignore small text sizes in the text bounding assert. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Ignore small text sizes in the text bounding assert. Seems we sometimes give back unduely large metrics for 0 text size. BUG=skia:2862 Committed: https://skia.googlesource.com/skia/+/d13291a5a3d2a79b5348ecc4a8e38ab1b6da85f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/core/SkRecordDraw.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
6 years, 4 months ago (2014-08-21 21:17:30 UTC) #1
reed1
lgtm
6 years, 4 months ago (2014-08-21 21:34:50 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-21 21:35:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/498503003/1
6 years, 4 months ago (2014-08-21 21:35:48 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 21:47:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as d13291a5a3d2a79b5348ecc4a8e38ab1b6da85f0

Powered by Google App Engine
This is Rietveld 408576698