Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 498503002: Docserver: Fixes for GitilesFileSystem (Closed)

Created:
6 years, 4 months ago by ahernandez
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Docserver: Fixes for GitilesFileSystem This patch resolves a few issues with GitilesFileSystem. BUG=404239 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291357

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -25 lines) Patch
M chrome/common/extensions/docs/server2/fake_fetchers.py View 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/server2/gitiles_file_system.py View 1 5 chunks +40 lines, -17 lines 0 comments Download
M chrome/common/extensions/docs/server2/gitiles_file_system_test.py View 1 2 5 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ahernandez
I decided to still upload a smaller CL with just some important changes to GitilesFS. ...
6 years, 4 months ago (2014-08-21 20:02:35 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/498503002/diff/20001/chrome/common/extensions/docs/server2/gitiles_file_system.py File chrome/common/extensions/docs/server2/gitiles_file_system.py (right): https://codereview.chromium.org/498503002/diff/20001/chrome/common/extensions/docs/server2/gitiles_file_system.py#newcode110 chrome/common/extensions/docs/server2/gitiles_file_system.py:110: entries = _ParseGitilesJson(json_data)['entries'] Maybe instead of ['entries'] this ...
6 years, 4 months ago (2014-08-21 20:58:29 UTC) #2
ahernandez
Can I get a quick lgtm on the new test please. I just want to ...
6 years, 4 months ago (2014-08-22 00:05:58 UTC) #3
not at google - send to devlin
https://codereview.chromium.org/498503002/diff/40001/chrome/common/extensions/docs/server2/gitiles_file_system_test.py File chrome/common/extensions/docs/server2/gitiles_file_system_test.py (right): https://codereview.chromium.org/498503002/diff/40001/chrome/common/extensions/docs/server2/gitiles_file_system_test.py#newcode153 chrome/common/extensions/docs/server2/gitiles_file_system_test.py:153: # Test that file systems at different commits still ...
6 years, 4 months ago (2014-08-22 00:19:17 UTC) #4
ahernandez
The CQ bit was checked by ahernandez.miralles@gmail.com
6 years, 4 months ago (2014-08-22 01:05:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahernandez.miralles@gmail.com/498503002/60001
6 years, 4 months ago (2014-08-22 01:09:17 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 07:42:02 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (60001) as 291357

Powered by Google App Engine
This is Rietveld 408576698