Issue 498493002: Couple more debugger tests working with Turbofan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 498493002: Couple more debugger tests working with Turbofan. (Closed)

Created:
6 years, 4 months ago by Jarin

Modified:
6 years, 4 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -8 lines)			Patch
M	src/compiler.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/ast-graph-builder.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler/operator-properties-inl.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/deoptimizer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/mjsunit/debug-backtrace-text.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/debug-break-inline.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/debug-scopes.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/mjsunit.status	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

LGTM, although I'm worried about the lack of test coverage.

6 years, 4 months ago (2014-08-22 07:12:13 UTC) #2

Jarin

6 years, 4 months ago (2014-08-22 07:44:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23292 (presubmit successful).