Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 498483002: Store vertex size in DrawState when setVertexAttribs is called (Closed)

Created:
6 years, 4 months ago by egdaniel
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Store vertex size in DrawState when setVertexAttribs is called This will avoid recalculating vertex size throughout code, and will allow for a set original vertex size once optimizations start removing VA's BUG=skia: Committed: https://skia.googlesource.com/skia/+/ab78e06830cb70410b0e9e4f96575e137867e89f

Patch Set 1 #

Patch Set 2 : Clean up #

Total comments: 2

Patch Set 3 : Remove VertexSize check #

Patch Set 4 : Add size assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/gpu/GrDrawState.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 2 3 5 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
egdaniel
6 years, 4 months ago (2014-08-21 19:26:40 UTC) #1
bsalomon
https://codereview.chromium.org/498483002/diff/20001/src/gpu/GrDrawState.cpp File src/gpu/GrDrawState.cpp (right): https://codereview.chromium.org/498483002/diff/20001/src/gpu/GrDrawState.cpp#newcode31 src/gpu/GrDrawState.cpp:31: a.fVertexSize != b.fVertexSize || Do we need this? Or ...
6 years, 4 months ago (2014-08-21 19:28:30 UTC) #2
egdaniel
https://codereview.chromium.org/498483002/diff/20001/src/gpu/GrDrawState.cpp File src/gpu/GrDrawState.cpp (right): https://codereview.chromium.org/498483002/diff/20001/src/gpu/GrDrawState.cpp#newcode31 src/gpu/GrDrawState.cpp:31: a.fVertexSize != b.fVertexSize || On 2014/08/21 19:28:30, bsalomon wrote: ...
6 years, 4 months ago (2014-08-21 21:30:30 UTC) #3
egdaniel
ptal
6 years, 4 months ago (2014-08-22 13:46:31 UTC) #4
bsalomon
lgtm, optionally could assert in op== that the sizes agree.
6 years, 4 months ago (2014-08-22 13:54:07 UTC) #5
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 4 months ago (2014-08-22 14:13:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/498483002/60001
6 years, 4 months ago (2014-08-22 14:13:13 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 14:19:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (60001) as ab78e06830cb70410b0e9e4f96575e137867e89f

Powered by Google App Engine
This is Rietveld 408576698