Issue 498453003: use globals to register custom effects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 498453003: use globals to register custom effects (Closed)

Created:
6 years, 4 months ago by reed1

Modified:
6 years, 4 months ago

Reviewers:
bungeman-skia, mtklein, caryclark

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

use globals to register custom effects NOTREECHECKS=True NOTRY=True Committed: https://skia.googlesource.com/skia/+/7daaaa4425ea083df437eea95ba6b38315ce98ad

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -24 lines)			Patch
	M	gm/imagefiltersbase.cpp	View		5 chunks	+30 lines, -16 lines	0 comments	Download
	M	gm/imagefiltersgraph.cpp	View		2 chunks	+15 lines, -8 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/498453003/1

6 years, 4 months ago (2014-08-21 17:47:04 UTC) #6

commit-bot: I haz the power

6 years, 4 months ago (2014-08-21 17:53:38 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (1) as 7daaaa4425ea083df437eea95ba6b38315ce98ad