EasyUnlock: Only do Bluetooth detection for chromeos.

EasyUnlock: Only do Bluetooth detection for chromeos.

Bluetooth detection on Mac triggers 500ms adapter polling and causes
performance regression. Since Easy unlock is only offered on ChromeOS
at the moment, disable Bluetooth detection for other platforms while
the polling problem is investigated.

BUG=404482, 399067
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291409

[xiyuan, 2014-08-21 17:14:28]

isherman@, could you also try it on Mac? Thanks.

[Ilya Sherman, 2014-08-22 01:27:20]

LGTM % nits.

https://codereview.chromium.org/498453002/diff/40001/chrome/browser/signin/ea...
File chrome/browser/signin/easy_unlock_service.cc (right):

https://codereview.chromium.org/498453002/diff/40001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.cc:294: // Only starts Bluetooth
detection for ChromeOS since the feature is
nit: starts -> start

https://codereview.chromium.org/498453002/diff/40001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.cc:295: // only offered at ChromeOS.
Note that http://crbug.com/404482 should be
nit: at -> on

https://codereview.chromium.org/498453002/diff/40001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.cc:296: // checked and make sure we
don't regress when re-enabling this,
nit: "Enabling this on non-ChromeOS platforms previously introduced a
performance regression: http://crbug.com/NNNNNN.  Make sure not to reintroduce a
performance regression if re-enabling on additional platforms."

[xiyuan, 2014-08-22 03:18:56]

https://codereview.chromium.org/498453002/diff/40001/chrome/browser/signin/ea...
File chrome/browser/signin/easy_unlock_service.cc (right):

https://codereview.chromium.org/498453002/diff/40001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.cc:294: // Only starts Bluetooth
detection for ChromeOS since the feature is
On 2014/08/22 01:27:19, Ilya Sherman wrote:
> nit: starts -> start

Done.

https://codereview.chromium.org/498453002/diff/40001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.cc:295: // only offered at ChromeOS.
Note that http://crbug.com/404482 should be
On 2014/08/22 01:27:19, Ilya Sherman wrote:
> nit: at -> on

Done.

https://codereview.chromium.org/498453002/diff/40001/chrome/browser/signin/ea...
chrome/browser/signin/easy_unlock_service.cc:296: // checked and make sure we
don't regress when re-enabling this,
On 2014/08/22 01:27:19, Ilya Sherman wrote:
> nit: "Enabling this on non-ChromeOS platforms previously introduced a
> performance regression: http://crbug.com/NNNNNN.  Make sure not to reintroduce
a
> performance regression if re-enabling on additional platforms."

Done.

[Ilya Sherman, 2014-08-22 03:29:55]

I've also double-checked that this does indeed prevent polling on Mac, as one
would expect :)

[xiyuan, 2014-08-22 04:06:13]

On 2014/08/22 03:29:55, Ilya Sherman wrote:
> I've also double-checked that this does indeed prevent polling on Mac, as one
> would expect :)

Thank you for checking it out. That brings peace to my mind.

[xiyuan, 2014-08-22 04:29:08]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-08-22 04:30:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xiyuan@chromium.org/498453002/60001

[commit-bot: I haz the power, 2014-08-22 05:25:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-22 06:17:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 06:17:32]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Ilya Sherman, 2014-08-22 06:20:28]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-08-22 06:21:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xiyuan@chromium.org/498453002/60001

[commit-bot: I haz the power, 2014-08-22 07:14:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[commit-bot: I haz the power, 2014-08-22 08:06:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 08:06:38]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[xiyuan, 2014-08-22 14:26:44]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2014-08-22 14:27:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xiyuan@chromium.org/498453002/60001

[commit-bot: I haz the power, 2014-08-22 15:26:14]

Committed patchset #3 (60001) as 291409