Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issue 498443002: Add missing test targets to the Linux ASan bots on chromium.memory. (Closed)

Created:
6 years, 4 months ago by earthdok
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add missing test targets to the Linux ASan bots on chromium.memory. When converting those bots to recipes in r287833, "unit" was replaced with "unit_tests". In fact, "unit" is a composite step that includes 5 other targets besides "unit_tests". This CL adds those targets back. This CL also adds accessibility_unittests and gfx_unittests, which presently run on the linux_asan trybot and on other waterfalls, but not on chromium.memory. The same should be done to cast_unittests and google_apis_unittests, once they are green under ASan. BUG=none R=glider@chromium.org TBR=phajdan.jr@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M testing/buildbot/chromium.memory.json View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
earthdok
ptal Michael: fyi
6 years, 4 months ago (2014-08-21 16:26:29 UTC) #1
earthdok
I think it's safe to assume that this has happened when converting other bots to ...
6 years, 4 months ago (2014-08-21 16:37:54 UTC) #2
Alexander Potapenko
LGTM
6 years, 4 months ago (2014-08-21 16:39:07 UTC) #3
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 4 months ago (2014-08-21 16:47:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/498443002/1
6 years, 4 months ago (2014-08-21 16:49:21 UTC) #5
Michael Achenbach
LGTM - good catch!
6 years, 4 months ago (2014-08-21 18:31:59 UTC) #6
earthdok
The CQ bit was unchecked by earthdok@chromium.org
6 years, 4 months ago (2014-08-21 20:30:17 UTC) #7
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 4 months ago (2014-08-21 20:30:17 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-21 20:30:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/498443002/1
6 years, 4 months ago (2014-08-21 20:31:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (1) as 291176
6 years, 4 months ago (2014-08-21 20:45:44 UTC) #11
earthdok
6 years, 4 months ago (2014-08-22 08:24:05 UTC) #12
Message was sent while issue was closed.
On 2014/08/21 16:37:54, earthdok wrote:
> I think it's safe to assume that this has happened when converting other bots
to
> recipes as well. We need to go through all the conversion CLs and fix them.

Follow-up: I've looked through the remaining configs and found that each config
which contains unit_tests also contains the other 5 targets, so looks like we're
good.

Powered by Google App Engine
This is Rietveld 408576698