Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 49843002: cros: Remove unused low memory margin code from sandbox and zygote (Closed)

Created:
7 years, 1 month ago by James Cook
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, agl, jln+watch_chromium.org
Visibility:
Public.

Description

cros: Remove unused low memory margin code from sandbox and zygote This code is unused - it was probably added long ago when we were trying to figure out the correct value for the memory margin. Removing it will make it easier to remove the setuid sandbox. BUG=312388 TEST=compiles, usual browser_tests R=jln@chromium.org TBR=joi@chromium.org for removing an unused method from content/public/browser/zygote_host_linux.h Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -86 lines) Patch
M content/browser/zygote_host/zygote_host_impl_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M content/public/browser/zygote_host_linux.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sandbox/linux/suid/common/sandbox.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sandbox/linux/suid/process_util_linux.c View 2 chunks +0 lines, -31 lines 0 comments Download
M sandbox/linux/suid/sandbox.c View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
James Cook
jln, PTAL jorgelo - just FYI
7 years, 1 month ago (2013-10-28 21:33:32 UTC) #1
Jorge Lucangeli Obes
On 2013/10/28 21:33:32, James Cook wrote: > jln, PTAL > > jorgelo - just FYI ...
7 years, 1 month ago (2013-10-28 21:45:23 UTC) #2
jln (very slow on Chromium)
Thanks, lgtm!
7 years, 1 month ago (2013-10-28 21:51:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/49843002/1
7 years, 1 month ago (2013-10-28 22:29:33 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=94127
7 years, 1 month ago (2013-10-29 03:23:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/49843002/1
7 years, 1 month ago (2013-10-29 14:50:31 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=94383
7 years, 1 month ago (2013-10-29 18:36:13 UTC) #7
James Cook
7 years, 1 month ago (2013-10-29 19:28:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r231611 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698