Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 498403002: Add an about:flag for enabling a reader mode toolbar icon. (Closed)

Created:
6 years, 4 months ago by Yaron
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/7f37900b4e8a1c0906ef409e939e8b5da61a4063 Cr-Commit-Position: refs/heads/master@{#291917}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_startup_flags.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
Yaron
cjhopman or nyquist: chrome/browser/android sky: the rest
6 years, 4 months ago (2014-08-25 20:22:02 UTC) #1
cjhopman
lgtm https://codereview.chromium.org/498403002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (left): https://codereview.chromium.org/498403002/diff/1/chrome/app/generated_resources.grd#oldcode14449 chrome/app/generated_resources.grd:14449: <!-- Prefetch search results experiment flags --> Remove ...
6 years, 4 months ago (2014-08-25 20:33:51 UTC) #2
sky
LGTM
6 years, 4 months ago (2014-08-25 20:49:07 UTC) #3
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 4 months ago (2014-08-25 20:50:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/498403002/20001
6 years, 4 months ago (2014-08-25 20:53:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-25 22:02:03 UTC) #6
Yaron
yfriedman@chromium.org changed reviewers: + isherman@chromium.org
6 years, 4 months ago (2014-08-25 22:49:41 UTC) #7
Yaron
+isherman. looks like i have to update a histogram for a cros unittest
6 years, 4 months ago (2014-08-25 22:49:41 UTC) #8
Ilya Sherman
histograms LGTM
6 years, 4 months ago (2014-08-25 22:57:00 UTC) #9
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 4 months ago (2014-08-25 22:57:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/498403002/40001
6 years, 4 months ago (2014-08-25 22:58:43 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-26 00:50:01 UTC) #12
Yaron
The CQ bit was unchecked by yfriedman@chromium.org
6 years, 4 months ago (2014-08-26 01:39:12 UTC) #13
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 4 months ago (2014-08-26 01:39:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/498403002/40001
6 years, 4 months ago (2014-08-26 01:39:36 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 01:41:40 UTC) #16
commit-bot: I haz the power
Failed to commit the patch.
6 years, 4 months ago (2014-08-26 01:41:42 UTC) #17
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 4 months ago (2014-08-26 01:44:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/498403002/40001
6 years, 4 months ago (2014-08-26 01:46:26 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 01:48:12 UTC) #20
commit-bot: I haz the power
Failed to commit the patch.
6 years, 4 months ago (2014-08-26 01:48:13 UTC) #21
nyquist
lgtm
6 years, 3 months ago (2014-08-26 05:35:17 UTC) #22
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 3 months ago (2014-08-26 16:29:20 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/498403002/40001
6 years, 3 months ago (2014-08-26 16:30:04 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 16:30:49 UTC) #25
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-26 16:30:50 UTC) #26
Yaron
Committed patchset #3 to pending queue manually as 86a6b34 (presubmit successful).
6 years, 3 months ago (2014-08-26 16:38:10 UTC) #27
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:43:16 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7f37900b4e8a1c0906ef409e939e8b5da61a4063
Cr-Commit-Position: refs/heads/master@{#291917}

Powered by Google App Engine
This is Rietveld 408576698