third_party/libjingle/BUILD.gn - Issue 498393002: Windows fixes for GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libjingle/BUILD.gn

Issue 498393002: Windows fixes for GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libjingle/BUILD.gn

diff --git a/third_party/libjingle/BUILD.gn b/third_party/libjingle/BUILD.gn

index cc83b297a24ef5bdff90aab3f2e7bf715869affa..777e08f96ad1543b2b78d6ebe33411905f90804a 100644

--- a/third_party/libjingle/BUILD.gn

+++ b/third_party/libjingle/BUILD.gn

@@ -255,8 +255,8 @@ static_library("libjingle") {

]

# From libjingle_common.gypi's conditions list.

- if (is_win && !nacl_untrusted_build) {

- cflags += [ "/wd4005", "\wd4267" ]

+ if (is_win) {

+ cflags = [ "/wd4005", "\wd4267" ]

scottmg 2014/08/25 19:40:55 why the heck is this \wd?

brettw 2014/08/25 19:42:40 Variety, I guess. Fixed.

}

forward_dependent_configs_from = [

@@ -337,7 +337,7 @@ source_set("peerconnnection_server") {

]

if (is_win) {

# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

- cflags += [ "/wd4309" ]

+ cflags = [ "/wd4309" ]

}

« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | no next file » | no next file with comments »