Swarming configuration files for chromoting integration tests

Swarming configuration files for chromoting integration tests.

BUG=

Committed: https://crrev.com/d90ba4c4e4ddf5c4cbb6cf812c9571d628e30567
Cr-Commit-Position: refs/heads/master@{#292785}

[Lei Lei, 2014-08-28 21:51:24]

leilei@chromium.org changed reviewers:
+ anandc@chromium.org, chaitali@chromium.org, maruel@chromium.org

[Lei Lei, 2014-08-29 20:19:48]

On 2014/08/28 21:51:24, Lei Lei wrote:
> mailto:leilei@chromium.org changed reviewers:
> + mailto:anandc@chromium.org, mailto:chaitali@chromium.org,
mailto:maruel@chromium.org

Friendly ping.

[M-A Ruel, 2014-08-29 20:57:16]

I never got the first email (?)

A few nits, but generally lgtm.

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
File testing/chromoting/chromoting_integration_tests.isolate (right):

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
testing/chromoting/chromoting_integration_tests.isolate:29: '../xvfb.py',
Move it to line 20

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
testing/chromoting/chromoting_integration_tests.isolate:31:
'<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
Move it to line 20

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/integ...
File testing/chromoting/integration_test.gyp (right):

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/integ...
testing/chromoting/integration_test.gyp:6: 'targets': [
Remove the empty section

[anandc1, 2014-08-29 21:11:28]

anandc@google.com changed reviewers:
+ anandc@google.com

[anandc1, 2014-08-29 21:11:29]

PTAL at comments. Thanks.

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
File testing/chromoting/chromoting_integration_tests.isolate (right):

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
testing/chromoting/chromoting_integration_tests.isolate:8: 'command': [
Has this succeeded when you run this on a Linux machine? 
For the Linux machines in our lab here, the browser_tests require setting up the
sandbox following steps here: 
https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
testing/chromoting/chromoting_integration_tests.isolate:16:
'--extension-name=Chromoting',
For Chromium builds, this extension name should work.
In Official builds, the extension name is "Chrome Remote Desktop".

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
testing/chromoting/chromoting_integration_tests.isolate:17:
'--enable-pixel-output-in-tests',
This is not essential, so may be removed.

[M-A Ruel, 2014-08-29 21:14:23]

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
File testing/chromoting/chromoting_integration_tests.isolate (right):

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
testing/chromoting/chromoting_integration_tests.isolate:8: 'command': [
On 2014/08/29 21:11:29, anandc1 wrote:
> Has this succeeded when you run this on a Linux machine? 
> For the Linux machines in our lab here, the browser_tests require setting up
the
> sandbox following steps here: 
> https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment

All the Chromium build slaves have the sandbox set already.

[Lei Lei, 2014-08-29 22:19:45]

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
File testing/chromoting/chromoting_integration_tests.isolate (right):

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
testing/chromoting/chromoting_integration_tests.isolate:8: 'command': [
On 2014/08/29 21:11:29, anandc1 wrote:
> Has this succeeded when you run this on a Linux machine? 
> For the Linux machines in our lab here, the browser_tests require setting up
the
> sandbox following steps here: 
> https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment

Yes, I ran it on both my dev box and swarming linux slave, both of them are
successful.
See one successful run on swarming:
https://chromium-swarm-dev.appspot.com/user/task/14823c763e81e01

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
testing/chromoting/chromoting_integration_tests.isolate:16:
'--extension-name=Chromoting',
On 2014/08/29 21:11:28, anandc1 wrote:
> For Chromium builds, this extension name should work.
> In Official builds, the extension name is "Chrome Remote Desktop".

We will build extension by ourselves, so the name should be 'Chromoting'.

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
testing/chromoting/chromoting_integration_tests.isolate:17:
'--enable-pixel-output-in-tests',
On 2014/08/29 21:11:28, anandc1 wrote:
> This is not essential, so may be removed.

Done.

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
testing/chromoting/chromoting_integration_tests.isolate:29: '../xvfb.py',
On 2014/08/29 20:57:16, M-A Ruel wrote:
> Move it to line 20

Done.

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/chrom...
testing/chromoting/chromoting_integration_tests.isolate:31:
'<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
On 2014/08/29 20:57:16, M-A Ruel wrote:
> Move it to line 20

Done.

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/integ...
File testing/chromoting/integration_test.gyp (right):

https://codereview.chromium.org/498373003/diff/20001/testing/chromoting/integ...
testing/chromoting/integration_test.gyp:6: 'targets': [
On 2014/08/29 20:57:16, M-A Ruel wrote:
> Remove the empty section

Done.

[anandc1, 2014-08-29 22:26:08]

thanks. lgtm

[Lei Lei, 2014-08-29 22:31:50]

The CQ bit was checked by leilei@chromium.org

[commit-bot: I haz the power, 2014-08-29 22:34:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/leilei@chromium.org/498373003/40001

[commit-bot: I haz the power, 2014-08-29 23:55:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Lei Lei, 2014-08-29 23:57:27]

The CQ bit was unchecked by leilei@chromium.org

[M-A Ruel, 2014-08-30 01:08:46]

On 2014/08/29 23:57:27, Lei Lei wrote:
> The CQ bit was unchecked by mailto:leilei@chromium.org

src/out/Release/chrome_100_percent.pak doesn't exist on mac.

Probably worth creating a browser_tests_base.isolate or something to reuse the
common files in browser_tests to not have to duplicate it there?

[Lei Lei, 2014-08-30 04:35:46]

The CQ bit was checked by leilei@chromium.org

[commit-bot: I haz the power, 2014-08-30 04:36:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/leilei@chromium.org/498373003/60001

[Lei Lei, 2014-08-30 07:31:20]

On 2014/08/30 01:08:46, M-A Ruel wrote:
> On 2014/08/29 23:57:27, Lei Lei wrote:
> > The CQ bit was unchecked by mailto:leilei@chromium.org
> 
> src/out/Release/chrome_100_percent.pak doesn't exist on mac.
> 
> Probably worth creating a browser_tests_base.isolate or something to reuse the
> common files in browser_tests to not have to duplicate it there?

I found a simple way to fix the build failure on mac, only added
chrome_100_percent.pak and locales on linux and win, see patch set#4.

Will consider to refactor browser_tests.isolate and
chromoting_integration_tests.isolate later to reduce the duplicated code.

[commit-bot: I haz the power, 2014-08-30 09:52:03]

Committed patchset #4 (id:60001) as 79b2275026565417b10e97e27b0708e4ebcb90c8

[commit-bot: I haz the power, 2014-09-10 03:14:08]

Patchset 4 (id:??) landed as
https://crrev.com/d90ba4c4e4ddf5c4cbb6cf812c9571d628e30567
Cr-Commit-Position: refs/heads/master@{#292785}

[jam, 2014-09-22 16:06:57]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/591163002/ by jam@chromium.org.

The reason for reverting is: This is slowing down the trybots because it's
uploading these files even though they're not used on trybots. look at how gpu
isolates that are only used on the GPU builders are handled (there's a gyp
variable which is only set by the builders which run these tests).