Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 498373002: Refactor pooling logic into a helper method Disable pooling when there are cert errors. Disable poo… (Closed)

Created:
6 years, 3 months ago by Ryan Hamilton
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

Merge 290497 "Refactor pooling logic into a helper method" > Refactor pooling logic into a helper method > Disable pooling when there are cert errors. > Disable pooling when pinning does not match for the new host. > > BUG=398925 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289433 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290320 > > Review URL: https://codereview.chromium.org/425803014 > > Cr-Commit-Position: refs/heads/master@{#290497} > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290497 0039d316-1c4b-4281-b951-d872f2087c98 > (cherry picked from commit 5db452206ce2503815abe55878179b2399cc906a) BUG=398925 TBR=matthewyuan Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/917753e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -56 lines) Patch
M net/http/http_network_session.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_response_body_drainer_unittest.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M net/quic/quic_client_session.h View 3 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_client_session.cc View 5 chunks +6 lines, -22 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 7 chunks +54 lines, -10 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 5 chunks +144 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.h View 4 chunks +11 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.cc View 4 chunks +43 lines, -12 lines 0 comments Download
M net/spdy/spdy_session_pool.h View 3 chunks +4 lines, -0 lines 0 comments Download
M net/spdy/spdy_session_pool.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 4 chunks +107 lines, -3 lines 0 comments Download
M net/spdy/spdy_test_utils.h View 2 chunks +18 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_utils.cc View 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ryan Hamilton
6 years, 3 months ago (2014-08-25 19:07:11 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 to pending queue manually as 917753e (presubmit
successful).

Powered by Google App Engine
This is Rietveld 408576698