Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 498303002: AppView internal API doesn't need to go through ExtensionsAPIClient anymore, since AppView is now i… (Closed)

Created:
6 years, 4 months ago by lfg
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Xi Han, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

AppView internal API doesn't need to go through ExtensionsAPIClient anymore, since AppView is now in extensions. BUG=352290 Committed: https://crrev.com/d99cf6ca506273472761112b4f8b1d1eba3150ed Cr-Commit-Position: refs/heads/master@{#292477}

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -72 lines) Patch
M chrome/browser/extensions/api/chrome_extensions_api_client.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.cc View 1 1 chunk +0 lines, -21 lines 0 comments Download
M extensions/browser/api/app_view/app_view_internal_api.cc View 3 chunks +9 lines, -12 lines 0 comments Download
M extensions/browser/api/extensions_api_client.h View 1 1 chunk +0 lines, -15 lines 0 comments Download
M extensions/browser/api/extensions_api_client.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
lfg
6 years, 4 months ago (2014-08-25 15:50:06 UTC) #1
Fady Samuel
lgtm
6 years, 4 months ago (2014-08-25 19:01:19 UTC) #2
lfg
lfg@chromium.org changed reviewers: + rockot@chromium.org
6 years, 4 months ago (2014-08-25 19:11:31 UTC) #3
lfg
rockot@chromium.org: Please review changes in All files.
6 years, 4 months ago (2014-08-25 19:11:31 UTC) #4
Ken Rockot(use gerrit already)
On 2014/08/25 19:11:31, lfg wrote: > mailto:rockot@chromium.org: Please review changes in > > All files. ...
6 years, 3 months ago (2014-08-28 19:26:51 UTC) #5
lfg
The CQ bit was checked by lfg@chromium.org
6 years, 3 months ago (2014-08-28 19:28:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lfg@chromium.org/498303002/1
6 years, 3 months ago (2014-08-28 19:28:50 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_arm64_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 19:34:44 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 19:36:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/6823)
6 years, 3 months ago (2014-08-28 19:36:17 UTC) #10
lfg
The CQ bit was checked by lfg@chromium.org
6 years, 3 months ago (2014-08-28 19:44:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lfg@chromium.org/498303002/20001
6 years, 3 months ago (2014-08-28 19:49:05 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 21:36:40 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 54f2a1e54cb299b80e19d2b0715554f003f89e22
6 years, 3 months ago (2014-08-28 22:13:38 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:02:44 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d99cf6ca506273472761112b4f8b1d1eba3150ed
Cr-Commit-Position: refs/heads/master@{#292477}

Powered by Google App Engine
This is Rietveld 408576698