Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 498293002: Fix reload of a tab that crashed in background. (Closed)

Created:
6 years, 4 months ago by ppi
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix reload of a tab that crashed in background. This patch fixes a trivial mistake that made the fix in https://codereview.chromium.org/459613007 a noop, and adds a regression unit-test. BUG=401859 Committed: https://crrev.com/7017a81991de983e12ab50dfc071c70e06979531 Cr-Commit-Position: refs/heads/master@{#291765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ppi
Hi Alex, ptal. Sigh.
6 years, 4 months ago (2014-08-25 15:26:32 UTC) #1
aelias_OOO_until_Jul13
lgtm
6 years, 4 months ago (2014-08-25 18:40:30 UTC) #2
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 4 months ago (2014-08-25 20:09:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/498293002/1
6 years, 4 months ago (2014-08-25 20:09:45 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-25 21:09:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 897a10a3efc940ef39f2bb7e0f78a2d905b83571
6 years, 4 months ago (2014-08-25 21:56:29 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:37:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7017a81991de983e12ab50dfc071c70e06979531
Cr-Commit-Position: refs/heads/master@{#291765}

Powered by Google App Engine
This is Rietveld 408576698