Change more PlatformCodeStubs to encode properties in the minor key.

Change more PlatformCodeStubs to encode properties in the minor key.

R=mvstanton@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23394

[mvstanton, 2014-08-26 09:05:02]

A couple nits, and then LGTM when addressed.

https://codereview.chromium.org/498283002/diff/1/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/498283002/diff/1/src/code-stubs.h#newcode808
src/code-stubs.h:808: class ArgumentCountBits : public
BitField<ArgumentCountKey, 0, 2> {};
I think you can add a static assert somewhere that enum ArgumentCountKey fits in
two bits.

https://codereview.chromium.org/498283002/diff/1/src/code-stubs.h#newcode847
src/code-stubs.h:847: class ExponentTypeBits : public BitField<ExponentType, 0,
2> {};
Same treatment here (protect against someone adding another enum value to
ExponentType without increasing # of bits).

[Yang, 2014-08-26 09:32:25]

https://codereview.chromium.org/498283002/diff/1/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/498283002/diff/1/src/code-stubs.h#newcode808
src/code-stubs.h:808: class ArgumentCountBits : public
BitField<ArgumentCountKey, 0, 2> {};
On 2014/08/26 09:05:02, mvstanton wrote:
> I think you can add a static assert somewhere that enum ArgumentCountKey fits
in
> two bits.

BitField::encode should already check whether the value fits.

[Yang, 2014-08-26 10:39:30]

Committed patchset #2 manually as 23394 (presubmit successful).