Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 498273002: Rename storage-related export macros and build targets (Closed)

Created:
6 years, 4 months ago by pilgrim_google
Modified:
6 years, 3 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), tzik, Lei Zhang, jam, extensions-reviews_chromium.org, nhiroki, kinuko+fileapi, tommycli, darin-cc_chromium.org, dcheng, Greg Billock, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename storage-related export macros and build targets Part of the refactoring effort to consolidate all fileapi/quota/webkit_database/webkit_blob-related code into a single namespace, directory, and component. Discussed here: https://groups.google.com/a/chromium.org/forum/#!topic/storage-dev/aQall8GOrS4 This is itself part of a larger refactoring effort to get rid of the webkit/ directory, as recorded in the following bug: BUG=338338 TBR=darin@chromium.org Committed: https://crrev.com/fa309edf9033cf74f2aa971cb4284d6849b7bc1a Cr-Commit-Position: refs/heads/master@{#291718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -277 lines) Patch
M android_webview/native/webview_native.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/blob_data_handle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/blob_storage_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/blob_url_request_job.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/blob_url_request_job_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/file_stream_reader.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/browser/blob/local_file_stream_reader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/view_blob_internals_job.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/database/database_quota_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/database/database_tracker.h View 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/browser/database/database_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/database/databases_table.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/database/vfs_backend.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/async_file_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/async_file_util_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/copy_or_move_file_validator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/copy_or_move_operation_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/dragged_file_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/external_mount_points.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_observers.h View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/file_permission_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_stream_writer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_backend.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_file_stream_reader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_file_util.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_runner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_options.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_quota_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_quota_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_url.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_usage_cache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_writer_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/isolated_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/local_file_stream_writer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/local_file_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/mount_points.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/native_file_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/plugin_private_file_system_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/quota/open_file_handle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/quota/open_file_handle_context.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/quota/quota_backend_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/quota/quota_reservation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/quota/quota_reservation_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/quota/quota_reservation_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/recursive_operation_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/sandbox_file_stream_writer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_isolated_origin_database.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_origin_database.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_origin_database_interface.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/sandbox_prioritized_origin_database.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/timed_task_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/transient_file_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/quota/quota_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/quota/quota_database.h View 5 chunks +6 lines, -6 lines 0 comments Download
M webkit/browser/quota/quota_manager.h View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/browser/quota/quota_manager_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/quota/quota_task.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/quota/quota_temporary_storage_evictor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/quota/special_storage_policy.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/quota/storage_monitor.h View 5 chunks +5 lines, -5 lines 0 comments Download
M webkit/browser/quota/storage_observer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/browser/quota/usage_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/browser/storage_export.h View 1 chunk +13 lines, -13 lines 0 comments Download
D webkit/browser/webkit_storage_browser_export.h View 1 chunk +0 lines, -34 lines 0 comments Download
M webkit/common/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/common/blob/blob_data.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/blob/scoped_file.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/database/database_connections.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/database/database_identifier.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/fileapi/directory_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/fileapi/file_system_info.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/fileapi/file_system_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/quota/quota_status_code.h View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/storage_common_export.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D webkit/common/webkit_storage_common_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
M webkit/storage_browser.gyp View 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/storage_common.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pilgrim_google
6 years, 4 months ago (2014-08-25 13:48:39 UTC) #1
tzik
lgtm
6 years, 4 months ago (2014-08-25 17:37:12 UTC) #2
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 4 months ago (2014-08-25 17:40:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/498273002/1
6 years, 4 months ago (2014-08-25 17:41:03 UTC) #4
darin (slow to review)
I'm a little confused by the renaming of webkit_storage_browser_export.h to storage_export.h. Should it keep the ...
6 years, 4 months ago (2014-08-25 18:24:19 UTC) #5
darin (slow to review)
LGTM
6 years, 4 months ago (2014-08-25 18:24:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 7bb52bec29ac3128e6604970f38b648423239299
6 years, 4 months ago (2014-08-25 18:25:34 UTC) #7
pilgrim_google
On 2014/08/25 18:24:19, darin wrote: > I'm a little confused by the renaming of webkit_storage_browser_export.h ...
6 years, 4 months ago (2014-08-25 19:40:16 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa309edf9033cf74f2aa971cb4284d6849b7bc1a
Cr-Commit-Position: refs/heads/master@{#291718}

Powered by Google App Engine
This is Rietveld 408576698