content/browser/frame_host/DEPS - Issue 49823002: Move navigation and frame tree classes to a new frame_host/ directory.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/frame_host/DEPS

Issue 49823002: Move navigation and frame tree classes to a new frame_host/ directory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 include_rules = [

	2 # The frame_host files should only call upwards in the layering via the

	3 # delegate interfaces.

	4 "-content/browser/web_contents",

	5 "-content/public/browser/web_contents.h",

	6 "-content/public/browser/web_contents_delegate.h",

	7 "-content/public/browser/web_contents_view.h",

	8 ]

	9
	jam 2013/10/29 01:26:00 nit: extra blank line nit: extra blank line nasko 2013/10/29 13:19:54 Done. Show quoted text On 2013/10/29 01:26:00, jam wrote: > nit: extra blank line Done.
	10

	11 specific_include_rules = {

	12 ".*_(unit\|browser)test\.cc": [

	13 # TODO(nasko): navigation_controller_impl_unitttests needs this,

	14 # investigate how to remove it.
	jam 2013/10/29 01:26:00 nit: it's ok if tests depend on other layers, we h nit: it's ok if tests depend on other layers, we have this with renderer_host for example nasko 2013/10/29 13:19:54 Done. Show quoted text On 2013/10/29 01:26:00, jam wrote: > nit: it's ok if tests depend on other layers, we have this with renderer_host > for example Done.
	15 "+content/browser/web_contents",

	16 "+content/browser/web_contents/web_contents_impl",
	jam 2013/10/29 01:26:00 nit: this isn't necessary given the line above? nit: this isn't necessary given the line above? nasko 2013/10/29 13:19:54 Done. Show quoted text On 2013/10/29 01:26:00, jam wrote: > nit: this isn't necessary given the line above? Done.
	17 "+content/public/browser/web_contents_delegate.h",

	18 ],

	19 ".*interstitial_page_impl\.cc": [

	20 # TODO(nasko): This should be removed once we remove

	21 # WebContentsObserver as the method of telling interstitial pages to

	22 # clean themselves up.

	23 "+content/browser/web_contents",

	24 "+content/browser/web_contents/web_contents_impl",
	jam 2013/10/29 01:26:00 ditto ditto nasko 2013/10/29 13:19:54 Done. Show quoted text On 2013/10/29 01:26:00, jam wrote: > ditto Done.
	25 "+content/public/browser/web_contents_delegate.h",

	26 ],

	27 }

OLD	NEW

« no previous file with comments | « content/browser/browser_url_handler_impl.cc ('k') | content/browser/frame_host/debug_urls.h » ('j') | no next file with comments »