Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 498223002: Add additional histogram events for prefetches to the prerender local (Closed)

Created:
6 years, 4 months ago by tburkard
Modified:
6 years, 3 months ago
CC:
chromium-reviews, davidben+watch_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, gavinp+prer_chromium.org, dominich+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/b2da221cd5f5f9589b95607397725e84125062d1 Cr-Commit-Position: refs/heads/master@{#292128}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/browser/prerender/prerender_local_predictor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_local_predictor.cc View 1 chunk +5 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
tburkard
Quick change for review, thanks.
6 years, 4 months ago (2014-08-25 11:54:35 UTC) #1
jkarlin
lgtm
6 years, 4 months ago (2014-08-25 11:58:32 UTC) #2
Alexei Svitkine (slow)
lgtm
6 years, 4 months ago (2014-08-25 21:22:49 UTC) #3
tburkard
rebase
6 years, 4 months ago (2014-08-25 21:33:28 UTC) #4
tburkard
The CQ bit was checked by tburkard@chromium.org
6 years, 4 months ago (2014-08-25 21:33:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tburkard@chromium.org/498223002/20001
6 years, 4 months ago (2014-08-25 21:35:51 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-25 22:38:53 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 23:18:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6712)
6 years, 4 months ago (2014-08-25 23:18:38 UTC) #9
tburkard
The CQ bit was checked by tburkard@chromium.org
6 years, 4 months ago (2014-08-26 08:12:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tburkard@chromium.org/498223002/40001
6 years, 4 months ago (2014-08-26 08:13:04 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-26 14:13:19 UTC) #12
tburkard
The CQ bit was checked by tburkard@chromium.org
6 years, 3 months ago (2014-08-26 14:20:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tburkard@chromium.org/498223002/60001
6 years, 3 months ago (2014-08-26 14:21:33 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-26 16:19:39 UTC) #15
tburkard
The CQ bit was checked by tburkard@chromium.org
6 years, 3 months ago (2014-08-26 16:23:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tburkard@chromium.org/498223002/80001
6 years, 3 months ago (2014-08-26 16:23:51 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-26 17:15:41 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 17:27:36 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/49648)
6 years, 3 months ago (2014-08-26 17:27:37 UTC) #20
tburkard
Committed patchset #5 to pending queue manually as 94766ca (presubmit successful).
6 years, 3 months ago (2014-08-27 09:23:55 UTC) #21
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:50:48 UTC) #22
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/b2da221cd5f5f9589b95607397725e84125062d1
Cr-Commit-Position: refs/heads/master@{#292128}

Powered by Google App Engine
This is Rietveld 408576698