Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 498213002: Mac QTKit video capture: Correct DCHECK #inputs==1 location (Closed)

Created:
6 years, 3 months ago by mcasas
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mac QTKit video capture: Correct DCHECK #inputs==1 location Gosh the DCHECK for #inputs == 1 was located _after_ removing the input XD Interesting that no one else hit this problem, including myself. BUG=407046 Committed: https://crrev.com/ba0aa5de6ef4ee7731c01502f06f60a250751297 Cr-Commit-Position: refs/heads/master@{#291742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/video/capture/mac/video_capture_device_qtkit_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
mcasas
xians@ PTAL
6 years, 3 months ago (2014-08-25 11:52:32 UTC) #1
mcasas
And tommi@: Owners RS
6 years, 3 months ago (2014-08-25 11:53:41 UTC) #2
no longer working on chromium
On 2014/08/25 11:53:41, mcasas wrote: > And tommi@: Owners RS huh, interesting, that makes perfect ...
6 years, 3 months ago (2014-08-25 11:59:06 UTC) #3
tommi (sloooow) - chröme
The CQ bit was checked by tommi@chromium.org
6 years, 3 months ago (2014-08-25 18:48:40 UTC) #4
tommi (sloooow) - chröme
lgtm
6 years, 3 months ago (2014-08-25 18:48:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/498213002/1
6 years, 3 months ago (2014-08-25 18:49:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 420a79f8802a7cf79369d023995c5c0a1c07f7ae
6 years, 3 months ago (2014-08-25 19:41:50 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:36:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba0aa5de6ef4ee7731c01502f06f60a250751297
Cr-Commit-Position: refs/heads/master@{#291742}

Powered by Google App Engine
This is Rietveld 408576698