Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 498193002: Disable slow BootstrapSandboxTest.DistributedNotifications_SandboxDeny (Closed)

Created:
6 years, 4 months ago by Paweł Hajdan Jr.
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/96711fba0704cfc7016c723d6354cddfa3435daa Cr-Commit-Position: refs/heads/master@{#291669}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M sandbox/mac/bootstrap_sandbox_unittest.mm View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
Committed patchset #1 to pending queue manually as f1bd7f7 (presubmit successful).
6 years, 4 months ago (2014-08-25 11:31:21 UTC) #1
Paweł Hajdan Jr.
TBR
6 years, 4 months ago (2014-08-25 11:31:58 UTC) #2
Robert Sesek
https://codereview.chromium.org/498193002/diff/1/sandbox/mac/bootstrap_sandbox_unittest.mm File sandbox/mac/bootstrap_sandbox_unittest.mm (right): https://codereview.chromium.org/498193002/diff/1/sandbox/mac/bootstrap_sandbox_unittest.mm#newcode67 sandbox/mac/bootstrap_sandbox_unittest.mm:67: TestTimeouts::action_timeout().InSeconds(), false); So is this not the right thing ...
6 years, 4 months ago (2014-08-25 14:19:37 UTC) #3
Robert Sesek
Ping. Can you please answer the question I asked above?
6 years, 3 months ago (2014-08-26 14:25:03 UTC) #4
Robert Sesek
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/508873003/ by rsesek@chromium.org. The ...
6 years, 3 months ago (2014-08-27 18:13:30 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:34:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96711fba0704cfc7016c723d6354cddfa3435daa
Cr-Commit-Position: refs/heads/master@{#291669}

Powered by Google App Engine
This is Rietveld 408576698