Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 498163002: Make benchmark runner understand chromium perf output. (Closed)

Created:
6 years, 4 months ago by Michael Achenbach
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Make benchmark runner understand chromium perf output. BUG=406405 LOG=n TEST=python -m unittest run_benchmarks_test R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24509

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -15 lines) Patch
M tools/run_perf.py View 1 3 chunks +24 lines, -9 lines 0 comments Download
M tools/unittests/run_perf_test.py View 1 1 chunk +17 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
6 years, 4 months ago (2014-08-25 08:14:26 UTC) #1
Michael Achenbach
Ping. How about this change now? Or should it be more generic then a graph/trace ...
6 years, 2 months ago (2014-10-09 13:23:51 UTC) #2
Benedikt Meurer
lgtm
6 years, 2 months ago (2014-10-10 04:03:32 UTC) #3
Michael Achenbach
6 years, 2 months ago (2014-10-10 07:12:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24509 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698