Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 49813002: Infer types for parameters even in the presence of InvocationMirror.delegate. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (revision 29416)
+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (working copy)
@@ -1541,9 +1541,9 @@
compiler);
return receiverType.refine(selector, compiler);
}
- // If [JSInvocationMirror._invokeOn] has been called, we must not create a
- // typed selector based on the receiver type.
- return backend.compiler.enabledInvokeOn ? selector.asUntyped : selector;
+ // If [JSInvocationMirror._invokeOn] is enabled, and this call
+ // might hit a `noSuchMethod`, we register an untyped selector.
+ return selector.extendIfReachesAll(compiler);
}
void registerMethodInvoke(HInvokeDynamic node) {

Powered by Google App Engine
This is Rietveld 408576698