Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 498123003: Remove implicit conversions from scoped_refptr to T* in google_apis/ (Closed)

Created:
6 years, 4 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/d4b710242244ed3a05a52ed4bfb68ea9737e280f Cr-Commit-Position: refs/heads/master@{#291821}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M google_apis/drive/auth_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/request_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_fetcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/merge_session_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_api_call_flow_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M google_apis/gcm/base/socket_stream.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/registration_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/unregistration_request.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + rogerta@chromium.org
6 years, 4 months ago (2014-08-25 21:39:03 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 4 months ago (2014-08-25 21:39:03 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
6 years, 4 months ago (2014-08-26 00:51:06 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 4 months ago (2014-08-26 00:53:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/498123003/1
6 years, 4 months ago (2014-08-26 00:54:50 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-26 01:29:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-26 01:44:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/43804)
6 years, 4 months ago (2014-08-26 01:44:54 UTC) #8
dcheng
Committed patchset #2 to pending queue manually as 71168f4 (presubmit successful).
6 years, 4 months ago (2014-08-26 02:07:42 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:39:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4b710242244ed3a05a52ed4bfb68ea9737e280f
Cr-Commit-Position: refs/heads/master@{#291821}

Powered by Google App Engine
This is Rietveld 408576698