Remove unused PPB_View_Dev

Remove unused PPB_View_Dev

TBR=binji@chromium.org

Committed: https://crrev.com/423f4a12e95d65fda88770ea2cb16eae0d994b52
Cr-Commit-Position: refs/heads/master@{#292086}

[raymes, 2014-08-26 00:21:32]

raymes@chromium.org changed reviewers:
+ dmichael@chromium.org

[dmichael (off chromium), 2014-08-26 22:06:39]

awesome, lgtm!

[raymes, 2014-08-27 00:52:55]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-08-27 00:54:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/498123002/40001

[commit-bot: I haz the power, 2014-08-27 01:50:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-27 01:53:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 01:53:23]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[raymes, 2014-08-27 02:49:38]

raymes@chromium.org changed reviewers:
+ binji@chromium.org

[raymes, 2014-08-27 02:49:57]

TBR=binji@chromium.org for native_client_sdk/src/libraries/ppapi

[raymes, 2014-08-27 02:50:11]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-08-27 02:50:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/raymes@chromium.org/498123002/40001

[raymes, 2014-08-27 02:52:27]

teravest: I just removed PPB_View_Dev - do you know if I am meant to
remove the entry from tools/metrics/histograms/histograms.xml? Or do I
leave it in?

On Wed, Aug 27, 2014 at 12:49 PM,  <raymes@chromium.org> wrote:
> TBR=binji@chromium.org for native_client_sdk/src/libraries/ppapi
>
> https://codereview.chromium.org/498123002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-08-27 02:54:38]

Committed patchset #3 (40001) as 2210d5fb49cd4b75972f2e304b29637c050de4f1

[dmichael (off chromium), 2014-08-27 14:46:44]

A revert of this CL (patchset #3) has been created in
https://codereview.chromium.org/512703003/ by dmichael@chromium.org.

The reason for reverting is: I should've checked sooner; this is apparently
still used by Flash. (See go/UMA, histograms, Pepper.InterfaceUsed).

[teravest, 2014-08-27 14:50:47]

> teravest: I just removed PPB_View_Dev - do you know if I am meant to
> remove the entry from tools/metrics/histograms/histograms.xml? Or do I
> leave it in?

You should leave the entry in histograms.xml; we don't remove entries there when
interfaces are removed.

[raymes, 2014-08-27 22:59:57]

Oh I did check with Xing (see the conversation below) but I should
have checked the histogram - it does seem like it's still used. Xing,
can you double check there is no usage of ViewDev? I guess there is
still some possibility that we are measuring wrongly.

> On Wed, Aug 27, 2014 at 1:03 PM, Xing Zhang <xzhang@adobe.com> wrote:
>> Thanks Raymes,
>>
>> Flash does not use PPB_View_Dev.
>>
>> Cheers,
>> Xing
>>
>> -----Original Message-----
>> From: Raymes Khoury [mailto:raymes@google.com]
>> Sent: Tuesday, August 26, 2014 5:53 PM
>> To: Xing Zhang
>> Subject: Removing PPB_View_Dev
>>
>> Hi Xing,
>>
>> Just a heads-up that I am about to remove PPB_View_Dev in chrome. I'm not
sure if flash is using this, but all of the functionality has now been
stabilized. So if flash is using it, it should switch to PPB_View (or View, the
c++ equivalent).
>>
>> The headers which flash might use would be:
>> ppb_view_dev.h
>> view_dev.h
>>
>> The CL is here:
>> https://codereview.chromium.org/498123002/
>>
>> Thanks!
>> Raymes

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Xing, 2014-08-27 23:10:51]

Sorry Raymes, my mistake, I should search the header file rather than
"PPB_View_Dev" in our platform code. Yes, we are still using it to track view
size.
I will update flash code to use the new interface next time we update PPAPI
source code.

Regards,
Xing

-----Original Message-----
From: raymes@google.com [mailto:raymes@google.com] On Behalf Of Raymes Khoury
Sent: Wednesday, August 27, 2014 3:59 PM
To: raymes@chromium.org; David Michael; Ben Smith; chromium-reviews;
yusukes+watch@chromium.org; Taiju Tsuiki; binji+watch@chromium.org; John
Abd-El-Malek; raymes+watch@chromium.org; teravest+watch@chromium.org; Darin
Fisher; nfullagar@chromium.org; piman+watch@chromium.org; Noel Allen;
sbc@chromium.org; ihf+watch@chromium.org; chrome-apps-syd-reviews; Xing Zhang
Subject: Re: Remove unused PPB_View_Dev (issue 498123002 by
raymes@chromium.org)

Oh I did check with Xing (see the conversation below) but I should have checked
the histogram - it does seem like it's still used. Xing, can you double check
there is no usage of ViewDev? I guess there is still some possibility that we
are measuring wrongly.

> On Wed, Aug 27, 2014 at 1:03 PM, Xing Zhang <xzhang@adobe.com> wrote:
>> Thanks Raymes,
>>
>> Flash does not use PPB_View_Dev.
>>
>> Cheers,
>> Xing
>>
>> -----Original Message-----
>> From: Raymes Khoury [mailto:raymes@google.com]
>> Sent: Tuesday, August 26, 2014 5:53 PM
>> To: Xing Zhang
>> Subject: Removing PPB_View_Dev
>>
>> Hi Xing,
>>
>> Just a heads-up that I am about to remove PPB_View_Dev in chrome. I'm not
sure if flash is using this, but all of the functionality has now been
stabilized. So if flash is using it, it should switch to PPB_View (or View, the
c++ equivalent).
>>
>> The headers which flash might use would be:
>> ppb_view_dev.h
>> view_dev.h
>>
>> The CL is here:
>> https://codereview.chromium.org/498123002/
>>
>> Thanks!
>> Raymes

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[raymes, 2014-08-28 00:19:36]

Thanks Xing!

On Thu, Aug 28, 2014 at 9:10 AM, Xing Zhang <xzhang@adobe.com> wrote:
> Sorry Raymes, my mistake, I should search the header file rather than
"PPB_View_Dev" in our platform code. Yes, we are still using it to track view
size.
> I will update flash code to use the new interface next time we update PPAPI
source code.
>
> Regards,
> Xing
>
> -----Original Message-----
> From: raymes@google.com [mailto:raymes@google.com] On Behalf Of Raymes Khoury
> Sent: Wednesday, August 27, 2014 3:59 PM
> To: raymes@chromium.org; David Michael; Ben Smith; chromium-reviews;
yusukes+watch@chromium.org; Taiju Tsuiki; binji+watch@chromium.org; John
Abd-El-Malek; raymes+watch@chromium.org; teravest+watch@chromium.org; Darin
Fisher; nfullagar@chromium.org; piman+watch@chromium.org; Noel Allen;
sbc@chromium.org; ihf+watch@chromium.org; chrome-apps-syd-reviews; Xing Zhang
> Subject: Re: Remove unused PPB_View_Dev (issue 498123002 by
raymes@chromium.org)
>
> Oh I did check with Xing (see the conversation below) but I should have
checked the histogram - it does seem like it's still used. Xing, can you double
check there is no usage of ViewDev? I guess there is still some possibility that
we are measuring wrongly.
>
>> On Wed, Aug 27, 2014 at 1:03 PM, Xing Zhang <xzhang@adobe.com> wrote:
>>> Thanks Raymes,
>>>
>>> Flash does not use PPB_View_Dev.
>>>
>>> Cheers,
>>> Xing
>>>
>>> -----Original Message-----
>>> From: Raymes Khoury [mailto:raymes@google.com]
>>> Sent: Tuesday, August 26, 2014 5:53 PM
>>> To: Xing Zhang
>>> Subject: Removing PPB_View_Dev
>>>
>>> Hi Xing,
>>>
>>> Just a heads-up that I am about to remove PPB_View_Dev in chrome. I'm not
sure if flash is using this, but all of the functionality has now been
stabilized. So if flash is using it, it should switch to PPB_View (or View, the
c++ equivalent).
>>>
>>> The headers which flash might use would be:
>>> ppb_view_dev.h
>>> view_dev.h
>>>
>>> The CL is here:
>>> https://codereview.chromium.org/498123002/
>>>
>>> Thanks!
>>> Raymes

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Xing, 2014-08-28 23:50:10]

Hi Raymes,

I just synced PPAPI to the latest Chromium revision, I noticed that you have
reverted that change. Do you still plan to update it? I think we can modify
Pepper flash to use the new interface.

Thanks,
Xing

-----Original Message-----
From: raymes@google.com [mailto:raymes@google.com] On Behalf Of Raymes Khoury
Sent: Wednesday, August 27, 2014 5:19 PM
To: Xing Zhang
Cc: David Michael; Ben Smith; chromium-reviews; yusukes+watch@chromium.org;
Taiju Tsuiki; binji+watch@chromium.org; John Abd-El-Malek;
raymes+watch@chromium.org; teravest+watch@chromium.org; Darin Fisher;
nfullagar@chromium.org; piman+watch@chromium.org; Noel Allen; sbc@chromium.org;
ihf+watch@chromium.org; chrome-apps-syd-reviews
Subject: Re: Remove unused PPB_View_Dev (issue 498123002 by
raymes@chromium.org)

Thanks Xing!

On Thu, Aug 28, 2014 at 9:10 AM, Xing Zhang <xzhang@adobe.com> wrote:
> Sorry Raymes, my mistake, I should search the header file rather than
"PPB_View_Dev" in our platform code. Yes, we are still using it to track view
size.
> I will update flash code to use the new interface next time we update PPAPI
source code.
>
> Regards,
> Xing
>
> -----Original Message-----
> From: raymes@google.com [mailto:raymes@google.com] On Behalf Of Raymes Khoury
> Sent: Wednesday, August 27, 2014 3:59 PM
> To: raymes@chromium.org; David Michael; Ben Smith; chromium-reviews;
yusukes+watch@chromium.org; Taiju Tsuiki; binji+watch@chromium.org; John
Abd-El-Malek; raymes+watch@chromium.org; teravest+watch@chromium.org; Darin
Fisher; nfullagar@chromium.org; piman+watch@chromium.org; Noel Allen;
sbc@chromium.org; ihf+watch@chromium.org; chrome-apps-syd-reviews; Xing Zhang
> Subject: Re: Remove unused PPB_View_Dev (issue 498123002 by
raymes@chromium.org)
>
> Oh I did check with Xing (see the conversation below) but I should have
checked the histogram - it does seem like it's still used. Xing, can you double
check there is no usage of ViewDev? I guess there is still some possibility that
we are measuring wrongly.
>
>> On Wed, Aug 27, 2014 at 1:03 PM, Xing Zhang <xzhang@adobe.com> wrote:
>>> Thanks Raymes,
>>>
>>> Flash does not use PPB_View_Dev.
>>>
>>> Cheers,
>>> Xing
>>>
>>> -----Original Message-----
>>> From: Raymes Khoury [mailto:raymes@google.com]
>>> Sent: Tuesday, August 26, 2014 5:53 PM
>>> To: Xing Zhang
>>> Subject: Removing PPB_View_Dev
>>>
>>> Hi Xing,
>>>
>>> Just a heads-up that I am about to remove PPB_View_Dev in chrome. I'm not
sure if flash is using this, but all of the functionality has now been
stabilized. So if flash is using it, it should switch to PPB_View (or View, the
c++ equivalent).
>>>
>>> The headers which flash might use would be:
>>> ppb_view_dev.h
>>> view_dev.h
>>>
>>> The CL is here:
>>> https://codereview.chromium.org/498123002/
>>>
>>> Thanks!
>>> Raymes

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[raymes, 2014-08-29 01:16:31]

Hi Xing,

Yes we would still like to get rid of the interface but we will wait
until Flash is no longer using it. It would be great if you could
switch to the stable interface.

Thanks!
Raymes

On Fri, Aug 29, 2014 at 9:50 AM, Xing Zhang <xzhang@adobe.com> wrote:
> Hi Raymes,
>
> I just synced PPAPI to the latest Chromium revision, I noticed that you have
reverted that change. Do you still plan to update it? I think we can modify
Pepper flash to use the new interface.
>
> Thanks,
> Xing
>
> -----Original Message-----
> From: raymes@google.com [mailto:raymes@google.com] On Behalf Of Raymes Khoury
> Sent: Wednesday, August 27, 2014 5:19 PM
> To: Xing Zhang
> Cc: David Michael; Ben Smith; chromium-reviews; yusukes+watch@chromium.org;
Taiju Tsuiki; binji+watch@chromium.org; John Abd-El-Malek;
raymes+watch@chromium.org; teravest+watch@chromium.org; Darin Fisher;
nfullagar@chromium.org; piman+watch@chromium.org; Noel Allen; sbc@chromium.org;
ihf+watch@chromium.org; chrome-apps-syd-reviews
> Subject: Re: Remove unused PPB_View_Dev (issue 498123002 by
raymes@chromium.org)
>
> Thanks Xing!
>
> On Thu, Aug 28, 2014 at 9:10 AM, Xing Zhang <xzhang@adobe.com> wrote:
>> Sorry Raymes, my mistake, I should search the header file rather than
"PPB_View_Dev" in our platform code. Yes, we are still using it to track view
size.
>> I will update flash code to use the new interface next time we update PPAPI
source code.
>>
>> Regards,
>> Xing
>>
>> -----Original Message-----
>> From: raymes@google.com [mailto:raymes@google.com] On Behalf Of Raymes
Khoury
>> Sent: Wednesday, August 27, 2014 3:59 PM
>> To: raymes@chromium.org; David Michael; Ben Smith; chromium-reviews;
yusukes+watch@chromium.org; Taiju Tsuiki; binji+watch@chromium.org; John
Abd-El-Malek; raymes+watch@chromium.org; teravest+watch@chromium.org; Darin
Fisher; nfullagar@chromium.org; piman+watch@chromium.org; Noel Allen;
sbc@chromium.org; ihf+watch@chromium.org; chrome-apps-syd-reviews; Xing Zhang
>> Subject: Re: Remove unused PPB_View_Dev (issue 498123002 by
raymes@chromium.org)
>>
>> Oh I did check with Xing (see the conversation below) but I should have
checked the histogram - it does seem like it's still used. Xing, can you double
check there is no usage of ViewDev? I guess there is still some possibility that
we are measuring wrongly.
>>
>>> On Wed, Aug 27, 2014 at 1:03 PM, Xing Zhang <xzhang@adobe.com> wrote:
>>>> Thanks Raymes,
>>>>
>>>> Flash does not use PPB_View_Dev.
>>>>
>>>> Cheers,
>>>> Xing
>>>>
>>>> -----Original Message-----
>>>> From: Raymes Khoury [mailto:raymes@google.com]
>>>> Sent: Tuesday, August 26, 2014 5:53 PM
>>>> To: Xing Zhang
>>>> Subject: Removing PPB_View_Dev
>>>>
>>>> Hi Xing,
>>>>
>>>> Just a heads-up that I am about to remove PPB_View_Dev in chrome. I'm not
sure if flash is using this, but all of the functionality has now been
stabilized. So if flash is using it, it should switch to PPB_View (or View, the
c++ equivalent).
>>>>
>>>> The headers which flash might use would be:
>>>> ppb_view_dev.h
>>>> view_dev.h
>>>>
>>>> The CL is here:
>>>> https://codereview.chromium.org/498123002/
>>>>
>>>> Thanks!
>>>> Raymes

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Xing, 2014-08-29 17:57:58]

Hi Raymes,

I have updated Pepper flash to switch from pp::ViewDev to pp::View.

Regards,
Xing

-----Original Message-----
From: raymes@google.com [mailto:raymes@google.com] On Behalf Of Raymes Khoury
Sent: Thursday, August 28, 2014 6:16 PM
To: Xing Zhang
Cc: David Michael; Ben Smith; chromium-reviews; yusukes+watch@chromium.org;
Taiju Tsuiki; binji+watch@chromium.org; John Abd-El-Malek;
raymes+watch@chromium.org; teravest+watch@chromium.org; Darin Fisher;
nfullagar@chromium.org; piman+watch@chromium.org; Noel Allen; sbc@chromium.org;
ihf+watch@chromium.org; chrome-apps-syd-reviews
Subject: Re: Remove unused PPB_View_Dev (issue 498123002 by
raymes@chromium.org)

Hi Xing,

Yes we would still like to get rid of the interface but we will wait until Flash
is no longer using it. It would be great if you could switch to the stable
interface.

Thanks!
Raymes

On Fri, Aug 29, 2014 at 9:50 AM, Xing Zhang <xzhang@adobe.com> wrote:
> Hi Raymes,
>
> I just synced PPAPI to the latest Chromium revision, I noticed that you have
reverted that change. Do you still plan to update it? I think we can modify
Pepper flash to use the new interface.
>
> Thanks,
> Xing
>
> -----Original Message-----
> From: raymes@google.com [mailto:raymes@google.com] On Behalf Of Raymes 
> Khoury
> Sent: Wednesday, August 27, 2014 5:19 PM
> To: Xing Zhang
> Cc: David Michael; Ben Smith; chromium-reviews; 
> yusukes+watch@chromium.org; Taiju Tsuiki; binji+watch@chromium.org; 
> John Abd-El-Malek; raymes+watch@chromium.org; 
> teravest+watch@chromium.org; Darin Fisher; nfullagar@chromium.org; 
> piman+watch@chromium.org; Noel Allen; sbc@chromium.org; 
> ihf+watch@chromium.org; chrome-apps-syd-reviews
> Subject: Re: Remove unused PPB_View_Dev (issue 498123002 by 
> raymes@chromium.org)
>
> Thanks Xing!
>
> On Thu, Aug 28, 2014 at 9:10 AM, Xing Zhang <xzhang@adobe.com> wrote:
>> Sorry Raymes, my mistake, I should search the header file rather than
"PPB_View_Dev" in our platform code. Yes, we are still using it to track view
size.
>> I will update flash code to use the new interface next time we update PPAPI
source code.
>>
>> Regards,
>> Xing
>>
>> -----Original Message-----
>> From: raymes@google.com [mailto:raymes@google.com] On Behalf Of 
>> Raymes Khoury
>> Sent: Wednesday, August 27, 2014 3:59 PM
>> To: raymes@chromium.org; David Michael; Ben Smith; chromium-reviews; 
>> yusukes+watch@chromium.org; Taiju Tsuiki; binji+watch@chromium.org; 
>> John Abd-El-Malek; raymes+watch@chromium.org; 
>> teravest+watch@chromium.org; Darin Fisher; nfullagar@chromium.org; 
>> piman+watch@chromium.org; Noel Allen; sbc@chromium.org; 
>> ihf+watch@chromium.org; chrome-apps-syd-reviews; Xing Zhang
>> Subject: Re: Remove unused PPB_View_Dev (issue 498123002 by 
>> raymes@chromium.org)
>>
>> Oh I did check with Xing (see the conversation below) but I should have
checked the histogram - it does seem like it's still used. Xing, can you double
check there is no usage of ViewDev? I guess there is still some possibility that
we are measuring wrongly.
>>
>>> On Wed, Aug 27, 2014 at 1:03 PM, Xing Zhang <xzhang@adobe.com> wrote:
>>>> Thanks Raymes,
>>>>
>>>> Flash does not use PPB_View_Dev.
>>>>
>>>> Cheers,
>>>> Xing
>>>>
>>>> -----Original Message-----
>>>> From: Raymes Khoury [mailto:raymes@google.com]
>>>> Sent: Tuesday, August 26, 2014 5:53 PM
>>>> To: Xing Zhang
>>>> Subject: Removing PPB_View_Dev
>>>>
>>>> Hi Xing,
>>>>
>>>> Just a heads-up that I am about to remove PPB_View_Dev in chrome. I'm not
sure if flash is using this, but all of the functionality has now been
stabilized. So if flash is using it, it should switch to PPB_View (or View, the
c++ equivalent).
>>>>
>>>> The headers which flash might use would be:
>>>> ppb_view_dev.h
>>>> view_dev.h
>>>>
>>>> The CL is here:
>>>> https://codereview.chromium.org/498123002/
>>>>
>>>> Thanks!
>>>> Raymes

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-09-10 02:49:21]

Patchset 3 (id:??) landed as
https://crrev.com/423f4a12e95d65fda88770ea2cb16eae0d994b52
Cr-Commit-Position: refs/heads/master@{#292086}