appengine/test_results/main.py - Issue 498083002: Make flakiness dashboard links to googlesource work post git migration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/test_results/main.py

Issue 498083002: Make flakiness dashboard links to googlesource work post git migration. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@deployable

Patch Set: fix upload Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/test_results/handlers/redirector.py ('K') | « appengine/test_results/handlers/redirector.py ('k') | appengine/test_results/static-dashboards/ui.js » ('j') | appengine/test_results/test/redirector_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/test_results/main.py

diff --git a/appengine/test_results/main.py b/appengine/test_results/main.py

index ab35157b4c0033a29835a1742783ff281695d272..bf7bfc70e56db435601b0cb25d7a636902321dd4 100644

--- a/appengine/test_results/main.py

+++ b/appengine/test_results/main.py

@@ -30,6 +30,7 @@ import webapp2

from handlers import buildershandler

from handlers import menu

+from handlers import redirector

from handlers import testfilehandler

routes = [

@@ -39,6 +40,8 @@ routes = [

('/testfile/?', testfilehandler.GetFile),

('/builders', buildershandler.GetBuilders),

('/updatebuilders', buildershandler.UpdateBuilders),

+ webapp2.Route('/rev', webapp2.RedirectHandler, defaults={

szager1 2014/09/04 20:51:32 nit: Maybe '/revrange'? Maybe '/rev' could redire

ghost stip (do not use) 2014/09/04 22:53:25 I agree with stefan here

ojan 2014/09/05 21:40:33 I went verbose with revision_range

+ '_uri': redirector.get_googlesource_url}),

('/', menu.Menu),

]