Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: athena/activity/activity_manager_impl.cc

Issue 498023003: Delete activity upon window deletion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « athena/activity/activity_manager_impl.h ('k') | athena/activity/activity_manager_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "athena/activity/public/activity_manager.h" 5 #include "athena/activity/activity_manager_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector>
9 8
10 #include "athena/activity/public/activity.h" 9 #include "athena/activity/public/activity.h"
11 #include "athena/activity/public/activity_view_manager.h" 10 #include "athena/activity/public/activity_view_manager.h"
12 #include "base/logging.h" 11 #include "base/logging.h"
13 12
14 namespace athena { 13 namespace athena {
15 14
16 namespace { 15 namespace {
17 16
18 ActivityManager* instance = NULL; 17 ActivityManager* instance = NULL;
19 18
20 class ActivityManagerImpl : public ActivityManager { 19 } // namespace
21 public: 20
22 ActivityManagerImpl() { 21 ActivityManagerImpl::ActivityManagerImpl() {
23 CHECK(!instance); 22 CHECK(!instance);
24 instance = this; 23 instance = this;
24 }
25
26 ActivityManagerImpl::~ActivityManagerImpl() {
27 while (!activities_.empty())
28 delete activities_.front();
29
30 CHECK_EQ(this, instance);
31 instance = NULL;
32 }
33
34 void ActivityManagerImpl::AddActivity(Activity* activity) {
35 CHECK(activities_.end() ==
36 std::find(activities_.begin(), activities_.end(), activity));
37 activities_.push_back(activity);
38 ActivityViewManager* manager = ActivityViewManager::Get();
39 manager->AddActivity(activity);
40 }
41
42 void ActivityManagerImpl::RemoveActivity(Activity* activity) {
43 std::vector<Activity*>::iterator find =
44 std::find(activities_.begin(), activities_.end(), activity);
45 if (find != activities_.end()) {
46 activities_.erase(find);
47 ActivityViewManager* manager = ActivityViewManager::Get();
48 manager->RemoveActivity(activity);
25 } 49 }
26 virtual ~ActivityManagerImpl() { 50 }
27 while (!activities_.empty())
28 delete activities_.front();
29 51
30 CHECK_EQ(this, instance); 52 void ActivityManagerImpl::UpdateActivity(Activity* activity) {
31 instance = NULL; 53 ActivityViewManager* manager = ActivityViewManager::Get();
32 } 54 manager->UpdateActivity(activity);
33 55 }
34 // ActivityManager:
35 virtual void AddActivity(Activity* activity) OVERRIDE {
36 CHECK(activities_.end() == std::find(activities_.begin(),
37 activities_.end(),
38 activity));
39 activities_.push_back(activity);
40 ActivityViewManager* manager = ActivityViewManager::Get();
41 manager->AddActivity(activity);
42 }
43
44 virtual void RemoveActivity(Activity* activity) OVERRIDE {
45 std::vector<Activity*>::iterator find = std::find(activities_.begin(),
46 activities_.end(),
47 activity);
48 if (find != activities_.end()) {
49 activities_.erase(find);
50
51 ActivityViewManager* manager = ActivityViewManager::Get();
52 manager->RemoveActivity(activity);
53 }
54 }
55
56 virtual void UpdateActivity(Activity* activity) OVERRIDE {
57 ActivityViewManager* manager = ActivityViewManager::Get();
58 manager->UpdateActivity(activity);
59 }
60
61 private:
62 std::vector<Activity*> activities_;
63
64 DISALLOW_COPY_AND_ASSIGN(ActivityManagerImpl);
65 };
66
67 } // namespace
68 56
69 // static 57 // static
70 ActivityManager* ActivityManager::Create() { 58 ActivityManager* ActivityManager::Create() {
71 ActivityViewManager::Create(); 59 ActivityViewManager::Create();
72 60
73 new ActivityManagerImpl(); 61 new ActivityManagerImpl();
74 CHECK(instance); 62 CHECK(instance);
75 return instance; 63 return instance;
76 } 64 }
77 65
78 ActivityManager* ActivityManager::Get() { 66 ActivityManager* ActivityManager::Get() {
79 return instance; 67 return instance;
80 } 68 }
81 69
82 void ActivityManager::Shutdown() { 70 void ActivityManager::Shutdown() {
83 CHECK(instance); 71 CHECK(instance);
84 delete instance; 72 delete instance;
85 ActivityViewManager::Shutdown(); 73 ActivityViewManager::Shutdown();
86 } 74 }
87 75
88 } // namespace athena 76 } // namespace athena
OLDNEW
« no previous file with comments | « athena/activity/activity_manager_impl.h ('k') | athena/activity/activity_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698