Delete activity upon window deletion

Delete activity upon window deletion
 (there was no leak reported because they're deleted upon shutdown)

A few minor cleanup/improvements
* Added shortcut to close athena. This doesn't update overview/split view mode.
  I'll address it in separate CL.
* Delete unnecessary athena_content_support_lib target. (I somehow missed this in review)
* Separate app_shell specific impl in extensions_delegate  (this is prep for athena+chrome)
* Remove ActivityWidget wrapper and use views::Widget instead, as it seems to be unnecessary. This is also prep for athena+chrome, where AppActivity should use NativeAppWindowViews.

BUG=None
TEST=coverted by unittests.
TBR=jamescook@chromium.org

Committed: https://crrev.com/dbcee380ef55e004ac7b56cf12f6b95c47adecff
Cr-Commit-Position: refs/heads/master@{#291935}

[sadrul, 2014-08-26 15:29:02]

https://codereview.chromium.org/498023003/diff/140001/athena/activity/activit...
File athena/activity/activity_view_manager_impl.cc (right):

https://codereview.chromium.org/498023003/diff/140001/athena/activity/activit...
athena/activity/activity_view_manager_impl.cc:84:
ActivityManager::Get()->RemoveActivity(iter->first);
It looks like closing the widget (e.g. by pressing the ctrl-w accelerator) will
remove the activity from the ActivityManager and ActivityViewManager. But it
doesn't look like the activity is actually deleted?

[oshima, 2014-08-26 16:05:41]

On 2014/08/26 15:29:02, sadrul wrote:
>
https://codereview.chromium.org/498023003/diff/140001/athena/activity/activit...
> File athena/activity/activity_view_manager_impl.cc (right):
> 
>
https://codereview.chromium.org/498023003/diff/140001/athena/activity/activit...
> athena/activity/activity_view_manager_impl.cc:84:
> ActivityManager::Get()->RemoveActivity(iter->first);
> It looks like closing the widget (e.g. by pressing the ctrl-w accelerator)
will
> remove the activity from the ActivityManager and ActivityViewManager. But it
> doesn't look like the activity is actually deleted?

I see. I believe I have to delete activity? I run athena_unittests with asan and
confirmed that it passes.

[oshima, 2014-08-26 16:14:38]

On 2014/08/26 16:05:41, oshima wrote:
> On 2014/08/26 15:29:02, sadrul wrote:
> >
>
https://codereview.chromium.org/498023003/diff/140001/athena/activity/activit...
> > File athena/activity/activity_view_manager_impl.cc (right):
> > 
> >
>
https://codereview.chromium.org/498023003/diff/140001/athena/activity/activit...
> > athena/activity/activity_view_manager_impl.cc:84:
> > ActivityManager::Get()->RemoveActivity(iter->first);
> > It looks like closing the widget (e.g. by pressing the ctrl-w accelerator)
> will
> > remove the activity from the ActivityManager and ActivityViewManager. But it
> > doesn't look like the activity is actually deleted?
> 
> I see. I believe I have to delete activity? I run athena_unittests with asan
and
> confirmed that it passes.

hold on. my patch someone got src/DEPS change. I'll upload new patch.

[oshima, 2014-08-26 16:16:47]

uploaded new patch. PTAL.

[sadrul, 2014-08-26 16:22:39]

Cool. LGTM

[oshima, 2014-08-26 16:39:51]

oshima@chromium.org changed reviewers:
+ jamescook@chromium.org

[oshima, 2014-08-26 16:41:18]

tbr'ing jamescook for moving +extensions/shell/browser deps
from athena/extensions/DEPS to athena/extensions/shell/DEPS

[oshima, 2014-08-26 16:41:23]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-08-26 16:42:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/498023003/180001

[commit-bot: I haz the power, 2014-08-26 17:46:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 17:46:14]

Failed to commit the patch.

[oshima, 2014-08-26 17:57:26]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-08-26 17:58:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/498023003/180001

[commit-bot: I haz the power, 2014-08-26 18:02:21]

Committed patchset #3 (180001) as e64f05db0ec342230ed34b25652d4f372722f6f0

[commit-bot: I haz the power, 2014-09-10 02:43:52]

Patchset 3 (id:??) landed as
https://crrev.com/dbcee380ef55e004ac7b56cf12f6b95c47adecff
Cr-Commit-Position: refs/heads/master@{#291935}