Allow sync with 2-factor StrongAuth accounts in ChromeOS.

chrome/browser/sync/profile_sync_service.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 #pragma once
 
 #include <string>
 
@@ skipping 337 matching lines @@
   // setting a passphrase as opposed to implicitly (from the users' perspective)
   // using their Google Account password.  An implicit SetPassphrase will *not*
   // *not* override an explicit passphrase set previously.
   virtual void SetPassphrase(const std::string& passphrase, bool is_explicit);
 
   // Returns whether processing changes is allowed.  Check this before doing
   // any model-modifying operations.
   bool ShouldPushChanges();
 
   const GURL& sync_service_url() const { return sync_service_url_; }
+  SigninManager* signin() { return signin_.get(); }

[John Gregg, 2010/11/18 00:05:30]

why are you making signin() public?  Would rather not if not necessary, and I
don't see a call site in your patch.

[stevenjb, 2010/11/18 00:11:09]

I didn't add signin(), just cros_user() (I eliminated a newline). signin() is
called in profile_sync_service_harness.cc.

[John Gregg, 2010/11/18 00:22:51]

Oh, never mind, read it incorrectly.  The sync/browser_signin parts LGTM.

+  const std::string& cros_user() const { return cros_user_; }
 
-  SigninManager* signin() { return &signin_; }
  protected:
   // Used by ProfileSyncServiceMock only.
   //
   // TODO(akalin): Separate this class out into an abstract
   // ProfileSyncService interface and a ProfileSyncServiceImpl class
   // so we don't need this hack anymore.
   ProfileSyncService();
 
   // Helper to install and configure a data type manager.
   void ConfigureDataTypeManager();
@@ skipping 86 matching lines @@
 
   // Various pieces of UI query this value to determine if they should show
   // an "Authenticating.." type of message.  We are the only central place
   // all auth attempts funnel through, so it makes sense to provide this.
   // As its name suggests, this should NOT be used for anything other than UI.
   bool is_auth_in_progress_;
 
   SyncSetupWizard wizard_;
 
   // Encapsulates user signin with TokenService.
-  SigninManager signin_;
+  scoped_ptr<SigninManager> signin_;
 
   // True if an unrecoverable error (e.g. violation of an assumed invariant)
   // occurred during syncer operation.  This value should be checked before
   // doing any work that might corrupt things further.
   bool unrecoverable_error_detected_;
 
   // A message sent when an unrecoverable error occurred.
   std::string unrecoverable_error_message_;
   scoped_ptr<tracked_objects::Location> unrecoverable_error_location_;
 
@@ skipping 49 matching lines @@
   // and is necessary because the nudge sync framework can drop nudges for
   // a wide variety of sync-related conditions (throttling, connections issues,
   // syncer paused, etc.).  It can only be removed correctly when the framework
   // is reworked to allow one-shot commands like clearing server data.
   base::OneShotTimer<ProfileSyncService> clear_server_data_timer_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
 };
 
 #endif  // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_