Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1347)

Issue 497993002: Add SK_API to SkTextBlob and SkTextBlobBuilder. (Closed)

Created:
6 years, 4 months ago by jbroman
Modified:
6 years, 4 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add SK_API to SkTextBlob and SkTextBlobBuilder. BUG=skia:2868 Committed: https://skia.googlesource.com/skia/+/3053dfaefd12abd220d961e7e4c661e6eb8ba90e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/core/SkTextBlob.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbroman
Ran into this when I tried to pull SkTextBlob into my Chromium build. Fix seems ...
6 years, 4 months ago (2014-08-23 22:30:36 UTC) #1
f(malita)
lgtm
6 years, 4 months ago (2014-08-24 13:41:06 UTC) #2
reed1
remember, this API is highly experimental, and subject to rapid/rabid changes. Please use with caution ...
6 years, 4 months ago (2014-08-25 12:58:37 UTC) #3
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 4 months ago (2014-08-25 13:15:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jbroman@chromium.org/497993002/1
6 years, 4 months ago (2014-08-25 13:15:22 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-25 13:22:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 3053dfaefd12abd220d961e7e4c661e6eb8ba90e

Powered by Google App Engine
This is Rietveld 408576698