Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 497843002: GuestViews should be able to specify task manager entries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More cleanup Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.h
diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h
index 8ce638c6f492624ba0beed54e3659e0515075dc3..0df12b94f750be318106bfb365a9574ef6de56d7 100644
--- a/extensions/browser/guest_view/guest_view_base.h
+++ b/extensions/browser/guest_view/guest_view_base.h
@@ -145,7 +145,16 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
//
// This should be the name of the API as it appears in the _api_features.json
// file.
- virtual const char* GetAPINamespace() = 0;
+ virtual const char* GetAPINamespace() const = 0;
+
+ // This method is to be implemented by the derived class. This method is the
+ // task prefix to show for a task produced by this GuestViewBase's derived
+ // type.
+ virtual int GetTaskPrefix() const = 0;
+
+ // This method is to be implemented by the derived class. This method is the
+ // title to show for a task produced by this GuestViewBase's derived type.
+ virtual base::string16 GetTaskTitle() const;
// This method is to be implemented by the derived class. Given a set of
// initialization parameters, a concrete subclass of GuestViewBase can
@@ -179,6 +188,8 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
const gfx::Size& min_size,
const gfx::Size& max_size);
+ base::string16 GetTitle() const;
+
base::WeakPtr<GuestViewBase> AsWeakPtr();
bool initialized() const { return initialized_; }

Powered by Google App Engine
This is Rietveld 408576698