Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3469)

Unified Diff: chrome/browser/task_manager/guest_information.cc

Issue 497843002: GuestViews should be able to specify task manager entries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added DEPS Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager/DEPS ('k') | chrome/browser/task_manager/task_manager_browsertest_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/guest_information.cc
diff --git a/chrome/browser/task_manager/guest_information.cc b/chrome/browser/task_manager/guest_information.cc
index 131503557b08857d161284c1554b4bf58136c5e4..4d3ccacad08faf12e66e4fbce93c8bc140348d6f 100644
--- a/chrome/browser/task_manager/guest_information.cc
+++ b/chrome/browser/task_manager/guest_information.cc
@@ -20,6 +20,8 @@
#include "content/public/browser/render_widget_host_iterator.h"
#include "content/public/browser/site_instance.h"
#include "content/public/browser/web_contents.h"
+#include "extensions/browser/guest_view/guest_view_base.h"
+#include "extensions/strings/grit/extensions_strings.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/image/image.h"
#include "ui/gfx/image/image_skia.h"
@@ -62,12 +64,15 @@ Resource::Type GuestResource::GetType() const {
base::string16 GuestResource::GetTitle() const {
WebContents* web_contents = GetWebContents();
- const int message_id = IDS_TASK_MANAGER_WEBVIEW_TAG_PREFIX;
- if (web_contents) {
- base::string16 title = util::GetTitleFromWebContents(web_contents);
- return l10n_util::GetStringFUTF16(message_id, title);
+ if (!web_contents) {
+ const int message_id = IDS_EXTENSION_TASK_MANAGER_WEBVIEW_TAG_PREFIX;
+ return l10n_util::GetStringFUTF16(message_id, base::string16());
}
- return l10n_util::GetStringFUTF16(message_id, base::string16());
+ extensions::GuestViewBase* guest =
+ extensions::GuestViewBase::FromWebContents(web_contents);
+ return l10n_util::GetStringFUTF16(
+ guest->GetTaskPrefix(),
+ util::GetTitleFromWebContents(web_contents));
}
gfx::ImageSkia GuestResource::GetIcon() const {
@@ -93,7 +98,7 @@ GuestInformation::~GuestInformation() {}
bool GuestInformation::CheckOwnership(WebContents* web_contents) {
// Guest WebContentses are created and owned internally by the content layer.
- return web_contents->IsSubframe();
+ return extensions::GuestViewBase::IsGuest(web_contents);
}
void GuestInformation::GetAll(const NewWebContentsCallback& callback) {
@@ -103,7 +108,7 @@ void GuestInformation::GetAll(const NewWebContentsCallback& callback) {
if (widget->IsRenderView()) {
content::RenderViewHost* rvh = content::RenderViewHost::From(widget);
WebContents* web_contents = WebContents::FromRenderViewHost(rvh);
- if (web_contents && web_contents->IsSubframe())
+ if (web_contents && extensions::GuestViewBase::IsGuest(web_contents))
callback.Run(web_contents);
}
}
« no previous file with comments | « chrome/browser/task_manager/DEPS ('k') | chrome/browser/task_manager/task_manager_browsertest_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698