extensions/browser/guest_view/guest_view_base.h - Issue 497843002: GuestViews should be able to specify task manager entries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 497843002: GuestViews should be able to specify task manager entries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Force derived types to come up with a task name Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/guest_view/app_view/app_view_guest.cc ('K') | « extensions/browser/guest_view/app_view/app_view_guest_delegate.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/guest_view_base.h

diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h

index 8ce638c6f492624ba0beed54e3659e0515075dc3..47a942bed9eeaa9757cc3d93769af07705df1349 100644

--- a/extensions/browser/guest_view/guest_view_base.h

+++ b/extensions/browser/guest_view/guest_view_base.h

@@ -145,7 +145,11 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

// This should be the name of the API as it appears in the _api_features.json

// file.

- virtual const char* GetAPINamespace() = 0;

+ virtual const char* GetAPINamespace() const = 0;

+ // This method is to be implemented by the derived class. This method is the

+ // task name to show for a task produced by this GuestViewBase's derived type.

+ virtual base::string16 GetTaskName() const = 0;

// This method is to be implemented by the derived class. Given a set of

// initialization parameters, a concrete subclass of GuestViewBase can