Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: extensions/browser/guest_view/app_view/app_view_guest_delegate.h

Issue 497843002: GuestViews should be able to specify task manager entries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Force derived types to come up with a task name Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/app_view/app_view_guest_delegate.h
diff --git a/extensions/browser/guest_view/app_view/app_view_guest_delegate.h b/extensions/browser/guest_view/app_view/app_view_guest_delegate.h
index 080c10ec261edbd1321bc849390381a6afac707b..272bbe2260855f4ac75021665117d261384de571 100644
--- a/extensions/browser/guest_view/app_view/app_view_guest_delegate.h
+++ b/extensions/browser/guest_view/app_view/app_view_guest_delegate.h
@@ -5,22 +5,38 @@
#ifndef EXTENSIONS_BROWSER_GUEST_VIEW_APP_VIEW_APP_VIEW_GUEST_DELEGATE_H_
#define EXTENSIONS_BROWSER_GUEST_VIEW_APP_VIEW_APP_VIEW_GUEST_DELEGATE_H_
+#include "base/strings/string16.h"
+
namespace content {
struct ContextMenuParams;
class WebContents;
}
namespace extensions {
+
+class AppViewGuest;
+
// Interface to handle communication between AppView (in extensions) with the
// browser.
class AppViewGuestDelegate {
public:
+ explicit AppViewGuestDelegate(AppViewGuest* app_view_guest);
virtual ~AppViewGuestDelegate();
+ // Returns the task name for <appview>.
+ virtual base::string16 GetTaskName() const = 0;
+
// Shows the context menu for the guest.
// Returns true if the context menu was handled.
virtual bool HandleContextMenu(content::WebContents* web_contents,
const content::ContextMenuParams& params) = 0;
+
+ AppViewGuest* app_view_guest() const { return app_view_guest_; }
+
+ private:
+ AppViewGuest* const app_view_guest_;
+
+ DISALLOW_COPY_AND_ASSIGN(AppViewGuestDelegate);
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698