GuestViews should be able to specify task manager entries

chrome/browser/guest_view/web_view/web_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/guest_view/web_view/web_view_guest.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/api/web_request/web_request_api.h"
@@ skipping 169 matching lines @@
 
 // static
 int WebViewGuest::GetViewInstanceId(WebContents* contents) {
   WebViewGuest* guest = FromWebContents(contents);
   if (!guest)
     return guestview::kInstanceIDNone;
 
   return guest->view_instance_id();
 }
 
-const char* WebViewGuest::GetAPINamespace() {
+const char* WebViewGuest::GetAPINamespace() const {
   return webview::kAPINamespace;
 }
 
+int WebViewGuest::GetTaskPrefix() const {
+  if (!web_view_guest_delegate_)
+    return 0;

[Charlie Reis, 2014/08/25 20:25:41]

Could we use IDS_TASK_MANAGER_WEBVIEW_TAG_PREFIX ("Webview:") instead of 0?  It
sounds like that might be a reasonable default for WebViewGuest, based on the
class name, and then we wouldn't need to worry about whether 0 is a valid task
prefix or not.

[Fady Samuel, 2014/08/25 23:05:52]

Done.

+  return web_view_guest_delegate_->GetTaskPrefix();
+}
+
 void WebViewGuest::CreateWebContents(
     const std::string& embedder_extension_id,
     int embedder_render_process_id,
     const base::DictionaryValue& create_params,
     const WebContentsCreatedCallback& callback) {
   content::RenderProcessHost* embedder_render_process_host =
       content::RenderProcessHost::FromID(embedder_render_process_id);
   std::string storage_partition_id;
   bool persist_storage = false;
   std::string storage_partition_string;
@@ skipping 918 matching lines @@
   WebViewGuest* guest =
       WebViewGuest::From(embedder_render_process_id(), new_window_instance_id);
   if (!guest)
     return;
 
   if (!allow)
     guest->Destroy();
 }
 
 }  // namespace extensions