Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 49783010: MIPS: Fix uint32-to-smi conversion in Lithium. (Closed) Base URL: https://github.com/v8/v8.git@gbl
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/lithium-mips.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1916 matching lines...) Expand 10 before | Expand all | Expand 10 after
1927 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result))); 1927 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result)));
1928 } else if (val->HasRange() && val->range()->IsInSmiRange()) { 1928 } else if (val->HasRange() && val->range()->IsInSmiRange()) {
1929 return DefineAsRegister(new(zone()) LSmiTag(value)); 1929 return DefineAsRegister(new(zone()) LSmiTag(value));
1930 } else { 1930 } else {
1931 LNumberTagI* result = new(zone()) LNumberTagI(value); 1931 LNumberTagI* result = new(zone()) LNumberTagI(value);
1932 return AssignEnvironment(AssignPointerMap(DefineAsRegister(result))); 1932 return AssignEnvironment(AssignPointerMap(DefineAsRegister(result)));
1933 } 1933 }
1934 } else if (to.IsSmi()) { 1934 } else if (to.IsSmi()) {
1935 HValue* val = instr->value(); 1935 HValue* val = instr->value();
1936 LOperand* value = UseRegister(val); 1936 LOperand* value = UseRegister(val);
1937 LInstruction* result = 1937 LInstruction* result = val->CheckFlag(HInstruction::kUint32)
1938 DefineSameAsFirst(new(zone()) LInteger32ToSmi(value)); 1938 ? DefineSameAsFirst(new(zone()) LUint32ToSmi(value))
1939 : DefineSameAsFirst(new(zone()) LInteger32ToSmi(value));
1939 if (val->HasRange() && val->range()->IsInSmiRange()) { 1940 if (val->HasRange() && val->range()->IsInSmiRange()) {
1940 return result; 1941 return result;
1941 } 1942 }
1942 return AssignEnvironment(result); 1943 return AssignEnvironment(result);
1943 } else { 1944 } else {
1944 ASSERT(to.IsDouble()); 1945 ASSERT(to.IsDouble());
1945 if (instr->value()->CheckFlag(HInstruction::kUint32)) { 1946 if (instr->value()->CheckFlag(HInstruction::kUint32)) {
1946 return DefineAsRegister( 1947 return DefineAsRegister(
1947 new(zone()) LUint32ToDouble(UseRegister(instr->value()))); 1948 new(zone()) LUint32ToDouble(UseRegister(instr->value())));
1948 } else { 1949 } else {
(...skipping 631 matching lines...) Expand 10 before | Expand all | Expand 10 after
2580 2581
2581 2582
2582 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2583 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2583 LOperand* object = UseRegister(instr->object()); 2584 LOperand* object = UseRegister(instr->object());
2584 LOperand* index = UseRegister(instr->index()); 2585 LOperand* index = UseRegister(instr->index());
2585 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2586 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2586 } 2587 }
2587 2588
2588 2589
2589 } } // namespace v8::internal 2590 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698