policy: Remove SigninManager from UserCloudPolicyStore.

chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/prefs/pref_service.h"
 #include "base/run_loop.h"
 #include "base/time/time.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 238 matching lines @@
     EXPECT_TRUE(register_completed_);
     EXPECT_TRUE(created_client_.get());
 
     // Now call to fetch policy - this should fire off a fetch request.
     MockDeviceManagementJob* fetch_request = NULL;
     EXPECT_CALL(device_management_service_,
                 CreateJob(DeviceManagementRequestJob::TYPE_POLICY_FETCH))
         .WillOnce(device_management_service_.CreateAsyncJob(&fetch_request));
     EXPECT_CALL(device_management_service_, StartJob(_, _, _, _, _, _, _))
         .Times(1);
+
     signin_service->FetchPolicyForSignedInUser(
+        kTestUser,
         created_client_.Pass(),
         base::Bind(&UserPolicySigninServiceTest::OnPolicyRefresh,
                    base::Unretained(this)));
 
     Mock::VerifyAndClearExpectations(this);
     ASSERT_TRUE(fetch_request);
 
     // UserCloudPolicyManager should now be initialized.
+    EXPECT_EQ(mock_store_->signin_username_, kTestUser);
     ASSERT_TRUE(manager_->core()->service());
 
     // Make the policy fetch succeed - this should result in a write to the
     // store and ultimately result in a call to OnPolicyRefresh().
     EXPECT_CALL(*mock_store_, Store(_));
     EXPECT_CALL(*this, OnPolicyRefresh(true)).Times(1);
 
     // Create a fake policy blob to deliver to the client.
     em::DeviceManagementResponse policy_blob;
     em::PolicyData policy_data;
@@ skipping 74 matching lines @@
   // Complete initialization of the store.
   mock_store_->NotifyStoreLoaded();
 
   // No oauth access token yet, so client registration should be deferred.
   ASSERT_FALSE(IsRequestActive());
 
   // Make oauth token available.
   GetTokenService()->IssueRefreshToken("oauth_login_refresh_token");
 
   // Client registration should be in progress since we now have an oauth token.
+  EXPECT_EQ(mock_store_->signin_username_, kTestUser);
   ASSERT_TRUE(IsRequestActive());
 }
 
 TEST_F(UserPolicySigninServiceTest, InitWhileSignedInOAuthError) {
   // Set the user as signed in.
   SigninManagerFactory::GetForProfile(profile_.get())->SetAuthenticatedUsername(
       kTestUser);
 
   // Let the SigninService know that the profile has been created.
   content::NotificationService::current()->Notify(
@@ skipping 39 matching lines @@
   SigninManagerFactory::GetForProfile(profile_.get())->SetAuthenticatedUsername(
       kTestUser);
 
   // Complete initialization of the store.
   mock_store_->NotifyStoreLoaded();
 
   // Make oauth token available.
   GetTokenService()->IssueRefreshToken("oauth_login_refresh_token");
 
   // UserCloudPolicyManager should be initialized.
+  EXPECT_EQ(mock_store_->signin_username_, kTestUser);
   ASSERT_TRUE(manager_->core()->service());
 
   // Client registration should be in progress since we have an oauth token.
   ASSERT_TRUE(IsRequestActive());
 }
 
 TEST_F(UserPolicySigninServiceTest, SignInWithNonEnterpriseUser) {
   EXPECT_CALL(*mock_store_, Clear());
   // Let the SigninService know that the profile has been created.
   content::NotificationService::current()->Notify(
@@ skipping 34 matching lines @@
   ASSERT_FALSE(manager_->core()->service());
 
   // Now sign in the user.
   SigninManagerFactory::GetForProfile(profile_.get())->SetAuthenticatedUsername(
       kTestUser);
 
   // Make oauth token available.
   GetTokenService()->IssueRefreshToken("oauth_login_refresh_token");
 
   // UserCloudPolicyManager should be initialized.
+  EXPECT_EQ(mock_store_->signin_username_, kTestUser);
   ASSERT_TRUE(manager_->core()->service());
 
   // Client registration should not be in progress since the store is not
   // yet initialized.
   ASSERT_FALSE(IsRequestActive());
 
   // Complete initialization of the store with no policy (unregistered client).
   mock_store_->NotifyStoreLoaded();
 
   // Client registration should be in progress since we have an oauth token.
@@ skipping 13 matching lines @@
   ASSERT_FALSE(manager_->core()->service());
 
   // Now sign in the user.
   SigninManagerFactory::GetForProfile(profile_.get())->SetAuthenticatedUsername(
       kTestUser);
 
   // Make oauth token available.
   GetTokenService()->IssueRefreshToken("oauth_login_refresh_token");
 
   // UserCloudPolicyManager should be initialized.
+  EXPECT_EQ(mock_store_->signin_username_, kTestUser);
   ASSERT_TRUE(manager_->core()->service());
 
   // Client registration should not be in progress since the store is not
   // yet initialized.
   ASSERT_FALSE(manager_->IsClientRegistered());
   ASSERT_FALSE(IsRequestActive());
 
   mock_store_->policy_.reset(new enterprise_management::PolicyData());
   mock_store_->policy_->set_request_token("fake token");
   mock_store_->policy_->set_device_id("fake client id");
 
   // Complete initialization of the store.
   mock_store_->NotifyStoreLoaded();
 
   // Client registration should not be in progress since the client should be
   // already registered.
   ASSERT_TRUE(manager_->IsClientRegistered());
   ASSERT_FALSE(IsRequestActive());
 }
 
 #endif  // !defined(OS_ANDROID)
 
 TEST_F(UserPolicySigninServiceTest, SignOutAfterInit) {
   EXPECT_CALL(*mock_store_, Clear());
+
   // Set the user as signed in.
   SigninManagerFactory::GetForProfile(profile_.get())->SetAuthenticatedUsername(
       kTestUser);
 
   // Let the SigninService know that the profile has been created.
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_PROFILE_ADDED,
       content::Source<Profile>(profile_.get()),
       content::NotificationService::NoDetails());
 
   // UserCloudPolicyManager should be initialized.
+  EXPECT_EQ(mock_store_->signin_username_, kTestUser);
   ASSERT_TRUE(manager_->core()->service());
 
   // Now sign out.
   SigninManagerFactory::GetForProfile(profile_.get())->SignOut();
 
   // UserCloudPolicyManager should be shut down.
   ASSERT_FALSE(manager_->core()->service());
 }
 
 TEST_F(UserPolicySigninServiceTest, RegisterPolicyClientOAuthFailure) {
@@ skipping 140 matching lines @@
   // Initiate a policy fetch request.
   MockDeviceManagementJob* fetch_request = NULL;
   EXPECT_CALL(device_management_service_,
               CreateJob(DeviceManagementRequestJob::TYPE_POLICY_FETCH))
       .WillOnce(device_management_service_.CreateAsyncJob(&fetch_request));
   EXPECT_CALL(device_management_service_, StartJob(_, _, _, _, _, _, _))
       .Times(1);
   UserPolicySigninService* signin_service =
       UserPolicySigninServiceFactory::GetForProfile(profile_.get());
   signin_service->FetchPolicyForSignedInUser(
+      kTestUser,
       client.Pass(),
       base::Bind(&UserPolicySigninServiceTest::OnPolicyRefresh,
                  base::Unretained(this)));
   ASSERT_TRUE(fetch_request);
 
   // Make the policy fetch fail.
   EXPECT_CALL(*this, OnPolicyRefresh(false)).Times(1);
   fetch_request->SendResponse(DM_STATUS_REQUEST_FAILED,
                               em::DeviceManagementResponse());
+
   // UserCloudPolicyManager should be initialized.
+  EXPECT_EQ(mock_store_->signin_username_, kTestUser);
   ASSERT_TRUE(manager_->core()->service());
 }
 
 TEST_F(UserPolicySigninServiceTest, FetchPolicySuccess) {
   ASSERT_NO_FATAL_FAILURE(TestSuccessfulSignin());
 }
 
 TEST_F(UserPolicySigninServiceTest, SignOutThenSignInAgain) {
   ASSERT_NO_FATAL_FAILURE(TestSuccessfulSignin());
 
@@ skipping 55 matching lines @@
   base::RunLoop().RunUntilIdle();
   EXPECT_FALSE(manager_->IsClientRegistered());
 #if !defined(OS_ANDROID)
   EXPECT_FALSE(signin_manager_->IsSignoutProhibited());
 #endif
 }
 
 }  // namespace
 
 }  // namespace policy