Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 497803002: Componentize component_updater: Copy test data over to components/test/data (Closed)

Created:
6 years, 4 months ago by tommycli
Modified:
6 years, 4 months ago
Reviewers:
waffles
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Componentize component_updater: Copy test data over to components/test/data As part of making component_updater a component, we are now moving over all the tests. Before we do that, we're copying the test data over. We are deleting it from the original spot in a separate CL. BUG=371463 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291470

Patch Set 1 #

Patch Set 2 : Add OWNERS file. #

Patch Set 3 : sigh: need to dcommit the jebgal... dir in separate CL due to CQ not respecting executable bit... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-20 lines, --24 lines) Patch
A + components/test/data/component_updater/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/binary_bsdiff_patch.bin View Binary file 0 comments Download
A + components/test/data/component_updater/binary_courgette_patch.bin View Binary file 0 comments Download
A + components/test/data/component_updater/binary_input.bin View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/binary_output.bin View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc.pem View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_changing_binary_file View Binary file 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_changing_text_file View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/a_static_text_file View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/commands.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f0 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f1 View Binary file 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2/f2 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/commands.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f2 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad/f3 View Binary file 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_changing_binary_file View Binary file 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_changing_text_file View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/a_static_text_file View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc/ihfokbkgjpifnbbojhneepfflplebdkc_2/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx View Binary file 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx View Binary file 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc_1to2_bad.crx View Binary file 0 comments Download
A + components/test/data/component_updater/ihfokbkgjpifnbbojhneepfflplebdkc_2.crx View Binary file 0 comments Download
A + components/test/data/component_updater/updatecheck_diff_reply_1.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/updatecheck_diff_reply_2.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/updatecheck_diff_reply_3.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/updatecheck_reply_1.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/updatecheck_reply_2.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/updatecheck_reply_3.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/updatecheck_reply_empty View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/component_updater/updatecheck_reply_noupdate.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/checkperms/checkperms.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tommycli
waffles: PTAL. As discussed, this is the step that just copies over the existing test ...
6 years, 4 months ago (2014-08-22 16:41:21 UTC) #1
waffles
lgtm
6 years, 4 months ago (2014-08-22 16:43:05 UTC) #2
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 4 months ago (2014-08-22 16:44:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/497803002/1
6 years, 4 months ago (2014-08-22 16:45:14 UTC) #4
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 4 months ago (2014-08-22 16:53:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/497803002/20001
6 years, 4 months ago (2014-08-22 16:54:17 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 17:47:22 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 17:50:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6096)
6 years, 4 months ago (2014-08-22 17:50:17 UTC) #9
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 4 months ago (2014-08-22 18:10:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/497803002/40001
6 years, 4 months ago (2014-08-22 18:11:47 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 19:20:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (40001) as 291470

Powered by Google App Engine
This is Rietveld 408576698