Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 497773004: IDL: Remove support for [LogPreviousValue] extended attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/attributes.cpp
diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp
index 640fd79b1a286751a0dfb74bddd93ee04ee3cff2..c76fa2e3c937cfc8255875379dcedac6555076fd 100644
--- a/Source/bindings/templates/attributes.cpp
+++ b/Source/bindings/templates/attributes.cpp
@@ -313,16 +313,7 @@ v8::Local<v8::String>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackI
{% else %}
if (contextData && contextData->activityLogger()) {
{% endif %}
- {% if attribute.activity_logging_include_old_value_for_setter %}
- {{cpp_class}}* impl = {{v8_class}}::toNative(info.Holder());
- {% if attribute.cpp_value_original %}
- {{attribute.cpp_type}} {{attribute.cpp_value}}({{attribute.cpp_value_original}});
- {% endif %}
- v8::Handle<v8::Value> originalValue = {{attribute.cpp_value_to_v8_value}};
- contextData->activityLogger()->logSetter("{{interface_name}}.{{attribute.name}}", v8Value, originalValue);
- {% else %}
contextData->activityLogger()->logSetter("{{interface_name}}.{{attribute.name}}", v8Value);
- {% endif %}
}
{% endif %}
{% if attribute.is_custom_element_callbacks or attribute.is_reflect %}

Powered by Google App Engine
This is Rietveld 408576698