Add GetValidBpc() check in CPDF_DIBSource::GetScanLine

Add GetValidBpc() check in CPDF_DIBSource::GetScanLine

BUG=406600, 406895
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/c2442f9

[Bo Xu, 2014-08-23 00:13:43]

Hi Tom, please review this.

[Tom Sepez, 2014-08-25 17:30:21]

https://codereview.chromium.org/497733005/diff/1/core/src/fpdfapi/fpdf_render...
File core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/497733005/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:1050: FX_DWORD bpc =
GetValidBpc();
Do we need to check for bcp == 0 error case?

https://codereview.chromium.org/497733005/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:1059: 
nit: stray blank line here.  This codebase seems hostile to blank lines :), but
if you want one, I'd put it one line earlier.

https://codereview.chromium.org/497733005/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:1068: if
(m_pStreamAcc->GetSize() >= (line + 1) * src_pitch.ValueOrDie()) {
nit: it may be better to move src_pitch.ValueOrDie() into a temporary rather
than calling it several times depending on how smart the compiler is ...

[Bo Xu, 2014-08-25 18:27:51]

https://codereview.chromium.org/497733005/diff/1/core/src/fpdfapi/fpdf_render...
File core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (right):

https://codereview.chromium.org/497733005/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:1050: FX_DWORD bpc =
GetValidBpc();
On 2014/08/25 17:30:21, Tom Sepez wrote:
> Do we need to check for bcp == 0 error case?

Done.

https://codereview.chromium.org/497733005/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:1059: 
On 2014/08/25 17:30:21, Tom Sepez wrote:
> nit: stray blank line here.  This codebase seems hostile to blank lines :),
but
> if you want one, I'd put it one line earlier.

Done.

https://codereview.chromium.org/497733005/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:1059: 
On 2014/08/25 17:30:21, Tom Sepez wrote:
> nit: stray blank line here.  This codebase seems hostile to blank lines :),
but
> if you want one, I'd put it one line earlier.

Agree, no blank line seems better.

https://codereview.chromium.org/497733005/diff/1/core/src/fpdfapi/fpdf_render...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:1068: if
(m_pStreamAcc->GetSize() >= (line + 1) * src_pitch.ValueOrDie()) {
On 2014/08/25 17:30:21, Tom Sepez wrote:
> nit: it may be better to move src_pitch.ValueOrDie() into a temporary rather
> than calling it several times depending on how smart the compiler is ... 

Done.

[Tom Sepez, 2014-08-25 18:32:37]

lgtm

[Bo Xu, 2014-08-25 20:31:18]

Committed patchset #2 manually as c2442f9 (presubmit successful).