ash/system/chromeos/brightness/tray_brightness.cc - Issue 497733002: Declaring the weak_ptr_factory in proper order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/chromeos/brightness/tray_brightness.cc

Issue 497733002: Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Maintaining function in proper order Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/system/chromeos/brightness/tray_brightness.cc

diff --git a/ash/system/chromeos/brightness/tray_brightness.cc b/ash/system/chromeos/brightness/tray_brightness.cc

index ee511ea97f67a877dd8898e25cbb63eea19bee56..5c804e85d71e4c9e98b4fa095320bec6c1d250ac 100644

--- a/ash/system/chromeos/brightness/tray_brightness.cc

+++ b/ash/system/chromeos/brightness/tray_brightness.cc

@@ -174,10 +174,10 @@ void BrightnessView::SliderDragEnded(views::Slider* slider) {

TrayBrightness::TrayBrightness(SystemTray* system_tray)

: SystemTrayItem(system_tray),

- weak_ptr_factory_(this),

brightness_view_(NULL),

current_percent_(100.0),

- got_current_percent_(false) {

+ got_current_percent_(false),

+ weak_ptr_factory_(this) {

// Post a task to get the initial brightness; the BrightnessControlDelegate

// isn't created yet.

base::MessageLoopForUI::current()->PostTask(