Declaring the weak_ptr_factory in proper order.

ash/shell.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SHELL_H_
 #define ASH_SHELL_H_
 
 #include <utility>
 #include <vector>
 
@@ skipping 681 matching lines @@
   // An event filter which handles system level gestures
   scoped_ptr<SystemGestureEventFilter> system_gesture_filter_;
 
   // An event filter that pre-handles global accelerators.
   scoped_ptr< ::wm::AcceleratorFilter> accelerator_filter_;
 
   // An event filter that pre-handles all key events to send them to an IME.
   scoped_ptr< ::wm::InputMethodEventFilter> input_method_filter_;
 
   scoped_ptr<DisplayManager> display_manager_;
-  scoped_ptr<base::WeakPtrFactory<DisplayManager> >
-      weak_display_manager_factory_;

[oshima, 2014/08/26 15:31:05]

This is for display_manager_, and defined after display_manager_,
so the order should be correct.

Does this have to be moved to the end as well? (I don't have objection. Just
checking)

[dmichael (off chromium), 2014/08/26 15:34:52]

It should be safe this way, and I think the Clang checker should not complain
about it. (If it does, let me know).

I'll leave it up to you two as to whether it should move.

[Anand Ratn (left samsung), 2014/08/28 06:15:07]

Done.

[Anand Ratn (left samsung), 2014/08/28 06:15:07]

Maintaining the order of display_manager_ in the new patchset.

 
   scoped_ptr<LocaleNotificationController> locale_notification_controller_;
 
   scoped_ptr<AccelerometerController> accelerometer_controller_;
 
 #if defined(OS_CHROMEOS)
   scoped_ptr<PowerEventObserver> power_event_observer_;
   scoped_ptr<ui::UserActivityPowerManagerNotifier> user_activity_notifier_;
   scoped_ptr<VideoActivityNotifier> video_activity_notifier_;
   scoped_ptr<StickyKeysController> sticky_keys_controller_;
@@ skipping 37 matching lines @@
   ObserverList<ShellObserver> observers_;
 
   // For testing only: simulate that a modal window is open
   bool simulate_modal_window_open_for_testing_;
 
   bool is_touch_hud_projection_enabled_;
 
   // Injected content::GPUDataManager support.
   scoped_ptr<GPUSupport> gpu_support_;
 
+  scoped_ptr<base::WeakPtrFactory<DisplayManager> >
+      weak_display_manager_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(Shell);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SHELL_H_