ChromeOS: Remove MockDBusThreadManager.

chromeos/dbus/stub_dbus_thread_manager_helper.h

Index: chromeos/dbus/stub_dbus_thread_manager_helper.h
diff --git a/chromeos/dbus/stub_dbus_thread_manager_helper.h b/chromeos/dbus/stub_dbus_thread_manager_helper.h
new file mode 100644
index 0000000000000000000000000000000000000000..f9af275f32d79a2c594da9aa596ea7815db5cab9
--- /dev/null
+++ b/chromeos/dbus/stub_dbus_thread_manager_helper.h
@@ -0,0 +1,18 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_DBUS_STUB_DBUS_THREAD_MANAGER_HELPER_H_
+#define CHROMEOS_DBUS_STUB_DBUS_THREAD_MANAGER_HELPER_H_
+
+#include "chromeos/chromeos_export.h"
+
+namespace chromeos {
+
+class FakeDBusThreadManager;
+
+CHROMEOS_EXPORT void SetStubClients(FakeDBusThreadManager* manager);

[satorux1, 2013/11/05 03:55:16]

Function comment is missing. 

Seems to me that this function is only used from
DBusThreadManager::InitializeWithStub(). Do you plan to use this from elsewhere?

Otherwise, would be nicer to put this in dbus_thread_manager.cc in favor of less
things to expose.

[pneubeck (no reviews), 2013/11/05 10:03:04]

By providing this separate function, we can do the following in tests:

FakeDBusThreadManager* manager = new Fake...;
SetStubClients(manager);
manager->SetShillManagerClient(my_client_);
DBusThreadManager::InitializeForTesting(manager);

This isn't used in any test so far. But I think this is very important, for
example for the FakeShillManagerClient. Currently it (and some other
ShillClients) relies on a GetTestInterface() in the ShillManagerClient (!)
interface and is implemented only by the FakeShillManagerClient.
With the above pattern, we can remove these GetTestInterface() methods.

[satorux1, 2013/11/05 10:18:56]

Oh I see. Does this have to be a function in a separate file? I thought it'd be
simpler to make it a member of FakeDBusThreadManager, like:

  manager->AddFakeClients();

[pneubeck (no reviews), 2013/11/05 10:58:44]

Since it's used in dbus_thread_manager.cc anyways, I agree that we can make it a
static function of the Fake*Manager.

[pneubeck (no reviews), 2013/11/05 16:14:59]

Done.

+
+}
+
+#endif  // CHROMEOS_DBUS_STUB_DBUS_THREAD_MANAGER_HELPER_H_