components/search_provider_logos/logo_cache.cc - Issue 497723004: Remove implicit conversions from scoped_refptr to T* in components/search_provider_logos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_provider_logos/logo_cache.cc

Issue 497723004: Remove implicit conversions from scoped_refptr to T* in components/search_provider_logos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/search_provider_logos/logo_cache.cc

diff --git a/components/search_provider_logos/logo_cache.cc b/components/search_provider_logos/logo_cache.cc

index 5858493ec2aa69a76d3f0dd1702cd2ec57e638d0..e83d826baa92821b22f3a011267dc4a1b259b74b 100644

--- a/components/search_provider_logos/logo_cache.cc

+++ b/components/search_provider_logos/logo_cache.cc

@@ -196,7 +196,7 @@ void LogoCache::WriteLogo(scoped_refptr<base::RefCountedMemory> encoded_image) {

if (!EnsureCacheDirectoryExists())

return;

- if (!metadata_ || !encoded_image) {

+ if (!metadata_ || !encoded_image.get()) {

DeleteLogoAndMetadata();

return;

}

« no previous file with comments | « no previous file | components/search_provider_logos/logo_cache_unittest.cc » ('j') | no next file with comments »