Merge willEnter/willExitFullScreen into didEnter/didExitFullScreen

Source/web/FullscreenController.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 38 matching lines @@
     return adoptPtr(new FullscreenController(webViewImpl));
 }
 
 FullscreenController::FullscreenController(WebViewImpl* webViewImpl)
     : m_webViewImpl(webViewImpl)
     , m_exitFullscreenPageScaleFactor(0)
     , m_isCancelingFullScreen(false)
 {
 }
 
-void FullscreenController::willEnterFullScreen()
+void FullscreenController::didEnterFullScreen()
 {
     if (!m_provisionalFullScreenElement)
         return;
 
-    // Ensure that this element's document is still attached.
-    Document& doc = m_provisionalFullScreenElement->document();
-    if (doc.frame()) {
-        Fullscreen::from(doc).willEnterFullScreenForElement(m_provisionalFullScreenElement.get());
-        m_fullScreenFrame = doc.frame();
-    }
-    m_provisionalFullScreenElement.clear();
-}
+    RefPtrWillBeRawPtr<Element> element = m_provisionalFullScreenElement.release();
+    Document& document = element->document();
+    m_fullScreenFrame = document.frame();
 
-void FullscreenController::didEnterFullScreen()
-{
     if (!m_fullScreenFrame)
         return;
 
-    if (Document* doc = m_fullScreenFrame->document()) {
-        if (Fullscreen::isFullScreen(*doc)) {
-            if (!m_exitFullscreenPageScaleFactor) {
-                m_exitFullscreenPageScaleFactor = m_webViewImpl->pageScaleFactor();
-                m_exitFullscreenScrollOffset = m_webViewImpl->mainFrame()->scrollOffset();
-                m_exitFullscreenPinchViewportOffset = m_webViewImpl->pinchViewportOffset();
-                m_webViewImpl->setPageScaleFactor(1.0f);
-                m_webViewImpl->setMainFrameScrollOffset(IntPoint());
-                m_webViewImpl->setPinchViewportOffset(FloatPoint());
+    if (!m_exitFullscreenPageScaleFactor) {
+        m_exitFullscreenPageScaleFactor = m_webViewImpl->pageScaleFactor();
+        m_exitFullscreenScrollOffset = m_webViewImpl->mainFrame()->scrollOffset();
+        m_exitFullscreenPinchViewportOffset = m_webViewImpl->pinchViewportOffset();
+        m_webViewImpl->setPageScaleFactor(1.0f);
+        m_webViewImpl->setMainFrameScrollOffset(IntPoint());
+        m_webViewImpl->setPinchViewportOffset(FloatPoint());
+    }
+
+    Fullscreen::from(document).didEnterFullScreenForElement(element.get());
+    ASSERT(Fullscreen::currentFullScreenElementFrom(document) == element);
+
+    if (RuntimeEnabledFeatures::overlayFullscreenVideoEnabled()) {
+        if (isHTMLMediaElement(element)) {
+            HTMLMediaElement* mediaElement = toHTMLMediaElement(element);
+            if (mediaElement->webMediaPlayer() && mediaElement->webMediaPlayer()->canEnterFullscreen()
+                // FIXME: There is no embedder-side handling in layout test mode.
+                && !LayoutTestSupport::isRunningLayoutTest()) {
+                mediaElement->webMediaPlayer()->enterFullscreen();
             }
-
-            Fullscreen::from(*doc).didEnterFullScreenForElement(0);
-            if (RuntimeEnabledFeatures::overlayFullscreenVideoEnabled()) {
-                Element* element = Fullscreen::currentFullScreenElementFrom(*doc);
-                ASSERT(element);
-                if (isHTMLMediaElement(*element)) {
-                    HTMLMediaElement* mediaElement = toHTMLMediaElement(element);
-                    if (mediaElement->webMediaPlayer() && mediaElement->webMediaPlayer()->canEnterFullscreen()
-                        // FIXME: There is no embedder-side handling in layout test mode.
-                        && !LayoutTestSupport::isRunningLayoutTest()) {
-                        mediaElement->webMediaPlayer()->enterFullscreen();
-                    }
-                    if (m_webViewImpl->layerTreeView())
-                        m_webViewImpl->layerTreeView()->setHasTransparentBackground(true);
-                }
-            }
+            if (m_webViewImpl->layerTreeView())
+                m_webViewImpl->layerTreeView()->setHasTransparentBackground(true);
         }
     }
 }
-
-void FullscreenController::willExitFullScreen()
-{
-    if (!m_fullScreenFrame)
-        return;
-
-    if (Document* doc = m_fullScreenFrame->document()) {
-        Fullscreen* fullscreen = Fullscreen::fromIfExists(*doc);
-        if (!fullscreen)
-            return;
-        if (fullscreen->isFullScreen(*doc)) {
-            // When the client exits from full screen we have to call fullyExitFullscreen to notify
-            // the document. While doing that, suppress notifications back to the client.
-            m_isCancelingFullScreen = true;
-            Fullscreen::fullyExitFullscreen(*doc);
-            m_isCancelingFullScreen = false;
-            fullscreen->willExitFullScreenForElement(0);
-            if (RuntimeEnabledFeatures::overlayFullscreenVideoEnabled() && m_webViewImpl->layerTreeView())
-                m_webViewImpl->layerTreeView()->setHasTransparentBackground(m_webViewImpl->isTransparent());
-        }
-    }
-}
 
 void FullscreenController::didExitFullScreen()
 {
     if (!m_fullScreenFrame)
         return;
 
-    if (Document* doc = m_fullScreenFrame->document()) {
-        if (Fullscreen* fullscreen = Fullscreen::fromIfExists(*doc)) {
+    if (Document* document = m_fullScreenFrame->document()) {
+        if (Fullscreen* fullscreen = Fullscreen::fromIfExists(*document)) {
             if (fullscreen->webkitCurrentFullScreenElement()) {
+                // When the client exits from full screen we have to call fullyExitFullscreen to notify
+                // the document. While doing that, suppress notifications back to the client.
+                m_isCancelingFullScreen = true;
+                Fullscreen::fullyExitFullscreen(*document);
+                m_isCancelingFullScreen = false;
+
+                if (RuntimeEnabledFeatures::overlayFullscreenVideoEnabled() && m_webViewImpl->layerTreeView())
+                    m_webViewImpl->layerTreeView()->setHasTransparentBackground(m_webViewImpl->isTransparent());
+
                 if (m_exitFullscreenPageScaleFactor) {
                     m_webViewImpl->setPageScaleFactor(m_exitFullscreenPageScaleFactor);
                     m_webViewImpl->setMainFrameScrollOffset(IntPoint(m_exitFullscreenScrollOffset));
                     m_webViewImpl->setPinchViewportOffset(m_exitFullscreenPinchViewportOffset);
                     m_exitFullscreenPageScaleFactor = 0;
                     m_exitFullscreenScrollOffset = IntSize();
                 }
 
                 fullscreen->didExitFullScreenForElement(0);
             }
         }
     }
 
     m_fullScreenFrame.clear();
 }
 
 void FullscreenController::enterFullScreenForElement(Element* element)
 {
     // We are already transitioning to fullscreen for a different element.
     if (m_provisionalFullScreenElement) {
         m_provisionalFullScreenElement = element;
         return;
     }
 
     // We are already in fullscreen mode.
     if (m_fullScreenFrame) {
         m_provisionalFullScreenElement = element;
-        willEnterFullScreen();
         didEnterFullScreen();
         return;
     }
 
     // We need to transition to fullscreen mode.
     if (WebViewClient* client = m_webViewImpl->client()) {
         if (client->enterFullScreen())
             m_provisionalFullScreenElement = element;
     }
 }
 
 void FullscreenController::exitFullScreenForElement(Element* element)
 {
     // The client is exiting full screen, so don't send a notification.
     if (m_isCancelingFullScreen)
         return;
     if (WebViewClient* client = m_webViewImpl->client())
         client->exitFullScreen();
 }
 
 } // namespace blink