Fix performance degradation in Havlak: prevent conflicting method recognizer kinds to be stored in …

runtime/vm/method_recognizer.h

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_METHOD_RECOGNIZER_H_
 #define VM_METHOD_RECOGNIZER_H_
 
 #include "vm/allocation.h"
 
 namespace dart {
 
 // (class-name, function-name, recognized enum, fingerprint).
 // When adding a new function add a 0 as fingerprint, build and run to get the
 // correct fingerprint from the mismatch error.
 #define OTHER_RECOGNIZED_LIST(V)                                               \
   V(::, identical, ObjectIdentical, 496869842)                                 \
   V(ClassID, getID, ClassIDgetID, 1322490980)                                  \
   V(Object, Object., ObjectConstructor, 1066669787)                            \
-  V(_List, _List., ObjectArrayConstructor, 1595327584)                         \
   V(_TypedList, _getInt8, ByteArrayBaseGetInt8, 1541411498)                    \
   V(_TypedList, _getUint8, ByteArrayBaseGetUint8, 1032404349)                  \
   V(_TypedList, _getInt16, ByteArrayBaseGetInt16, 381073990)                   \
   V(_TypedList, _getUint16, ByteArrayBaseGetUint16, 1142676276)                \
   V(_TypedList, _getInt32, ByteArrayBaseGetInt32, 330269934)                   \
   V(_TypedList, _getUint32, ByteArrayBaseGetUint32, 59490554)                  \
   V(_TypedList, _getFloat32, ByteArrayBaseGetFloat32, 393003933)               \
   V(_TypedList, _getFloat64, ByteArrayBaseGetFloat64, 1792407200)              \
   V(_TypedList, _getFloat32x4, ByteArrayBaseGetFloat32x4, 1338379857)          \
   V(_TypedList, _getInt32x4, ByteArrayBaseGetInt32x4, 1469917805)              \
   V(_TypedList, _setInt8, ByteArrayBaseSetInt8, 433348464)                     \
   V(_TypedList, _setUint8, ByteArrayBaseSetUint8, 149406583)                   \
   V(_TypedList, _setInt16, ByteArrayBaseSetInt16, 805477162)                   \
   V(_TypedList, _setUint16, ByteArrayBaseSetUint16, 888580944)                 \
   V(_TypedList, _setInt32, ByteArrayBaseSetInt32, 1708248181)                  \
   V(_TypedList, _setUint32, ByteArrayBaseSetUint32, 1863152792)                \
   V(_TypedList, _setFloat32, ByteArrayBaseSetFloat32, 1148703855)              \
   V(_TypedList, _setFloat64, ByteArrayBaseSetFloat64, 972883980)               \
   V(_TypedList, _setFloat32x4, ByteArrayBaseSetFloat32x4, 950522310)           \
   V(_TypedList, _setInt32x4, ByteArrayBaseSetInt32x4, 1301138078)              \
-  V(_StringBase, [], StringBaseCharAt, 1512210677)                             \
   V(_StringBase, _interpolate, StringBaseInterpolate, 1758627989)              \
   V(_IntegerImplementation, toDouble, IntegerToDouble, 1084977108)             \
   V(_IntegerImplementation, _leftShiftWithMask32, IntegerLeftShiftWithMask32,  \
       597111055)                                                               \
-  V(_Double, .fromInteger, DoubleFromInteger, 999771940)                       \
   V(_Double, truncateToDouble, DoubleTruncate, 2117801967)                     \
   V(_Double, roundToDouble, DoubleRound, 2124216110)                           \
   V(_Double, floorToDouble, DoubleFloor, 968600699)                            \
   V(_Double, ceilToDouble, DoubleCeil, 1779929274)                             \
   V(_Double, _modulo, DoubleMod, 1473971007)                                   \
   V(_Double, _add, DoubleAdd, 1570715125)                                      \
   V(_Double, _sub, DoubleSub, 1466395310)                                      \
   V(_Double, _mul, DoubleMul, 546441193)                                       \
   V(_Double, _div, DoubleDiv, 1201505037)                                      \
   V(::, sin, MathSin, 1741396147)                                              \
@@ skipping 101 matching lines @@
   V(_Double, <, Double_lessThan, 2080387973)                                   \
   V(_Double, <=, Double_lessEqualThan, 106225572)                              \
   V(_Double, ==, Double_equal, 2093918133)                                     \
   V(_Double, +, Double_add, 1646350451)                                        \
   V(_Double, -, Double_sub, 1477459276)                                        \
   V(_Double, *, Double_mul, 1334580777)                                        \
   V(_Double, /, Double_div, 1938037155)                                        \
   V(_Double, get:isNaN, Double_getIsNaN, 843050033)                            \
   V(_Double, get:isNegative, Double_getIsNegative, 1637875580)                 \
   V(_Double, _mulFromInteger, Double_mulFromInteger, 1594796483)               \
-  V(_Double, .fromInteger, Double_fromInteger, 999771940)                      \
+  V(_Double, .fromInteger, DoubleFromInteger, 999771940)                       \
   V(_List, ., ObjectArrayAllocate, 1595327584)                                 \
   V(_List, get:length, ObjectArrayLength, 1181352729)                          \
   V(_List, [], ObjectArrayGetIndexed, 795612476)                               \
   V(_List, []=, ObjectArraySetIndexed, 1288827575)                             \
   V(_GrowableList, .withData, GrowableArray_Allocate, 732923072)               \
   V(_GrowableList, get:length, GrowableArrayLength, 778505107)                 \
   V(_GrowableList, get:_capacity, GrowableArrayCapacity, 555140075)            \
   V(_GrowableList, [], GrowableArrayGetIndexed, 919108233)                     \
   V(_GrowableList, []=, GrowableArraySetIndexed, 1218649853)                   \
   V(_GrowableList, _setLength, GrowableArraySetLength, 89389299)               \
   V(_GrowableList, _setData, GrowableArraySetData, 2126927509)                 \
   V(_GrowableList, add, GrowableArray_add, 1899133961)                         \
   V(_ImmutableList, [], ImmutableArrayGetIndexed, 1990177341)                  \
   V(_ImmutableList, get:length, ImmutableArrayLength, 274917727)               \
   V(Object, ==, ObjectEquals, 1068471689)                                      \
   V(_StringBase, get:hashCode, String_getHashCode, 2102906241)                 \
   V(_StringBase, get:isEmpty, StringBaseIsEmpty, 49873871)                     \
   V(_StringBase, get:length, StringBaseLength, 784399628)                      \
   V(_StringBase, codeUnitAt, StringBaseCodeUnitAt, 397735324)                  \
-  V(_StringBase, [], StringBase_charAt, 1512210677)                            \
+  V(_StringBase, [], StringBaseCharAt, 1512210677)                             \
   V(_OneByteString, get:hashCode, OneByteString_getHashCode, 1111837929)       \
   V(_OneByteString, _substringUncheckedNative,                                 \
       OneByteString_substringUnchecked, 1527498975)                            \
   V(_OneByteString, _setAt, OneByteStringSetAt, 468605749)                     \
   V(_OneByteString, _allocate, OneByteString_allocate, 2035417022)             \
   V(_OneByteString, ==, OneByteString_equality, 1727047023)                    \
   V(_TwoByteString, ==, TwoByteString_equality, 951149689)                     \
 
 
 #define CORE_INTEGER_LIB_INTRINSIC_LIST(V)                                     \
@@ skipping 187 matching lines @@
   static Kind RecognizeKind(const Function& function);
   static bool AlwaysInline(const Function& function);
   static bool PolymorphicTarget(const Function& function);
   static const char* KindToCString(Kind kind);
   static void InitializeState();
 };
 
 }  // namespace dart
 
 #endif  // VM_METHOD_RECOGNIZER_H_