Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc

Issue 497583003: Fix test failures in ToolbarViewInteractiveUITest.TestWrenchMenuOpensOnDrag (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc b/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
index 0405c3fd96377bf612a44b0393439753d01f01cf..c0db6e4fd9319ac46f95f4d7e65cea4a99b60c73 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
@@ -48,6 +48,7 @@ class ToolbarViewInteractiveUITest : public ExtensionBrowserTest {
// InProcessBrowserTest:
virtual void SetUpCommandLine(base::CommandLine* command_line) OVERRIDE;
virtual void SetUpOnMainThread() OVERRIDE;
+ virtual void TearDownOnMainThread() OVERRIDE;
ToolbarView* toolbar_view_;
@@ -125,6 +126,8 @@ void ToolbarViewInteractiveUITest::SetUpCommandLine(
// are constructed.
feature_override_.reset(new extensions::FeatureSwitch::ScopedOverride(
extensions::FeatureSwitch::extension_action_redesign(), true));
+ BrowserActionsContainer::disable_animations_during_testing_ = true;
+ WrenchToolbarButton::g_open_wrench_immediately_for_testing = true;
}
void ToolbarViewInteractiveUITest::SetUpOnMainThread() {
@@ -134,11 +137,13 @@ void ToolbarViewInteractiveUITest::SetUpOnMainThread() {
browser_actions_ = toolbar_view_->browser_actions();
}
+void ToolbarViewInteractiveUITest::TearDownOnMainThread() {
+ BrowserActionsContainer::disable_animations_during_testing_ = false;
+ WrenchToolbarButton::g_open_wrench_immediately_for_testing = false;
+}
+
IN_PROC_BROWSER_TEST_F(ToolbarViewInteractiveUITest,
MAYBE(TestWrenchMenuOpensOnDrag)) {
- BrowserActionsContainer::disable_animations_during_testing_ = true;
- WrenchToolbarButton::g_open_wrench_immediately_for_testing = true;
-
// Load an extension that has a browser action.
ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("api_test")
.AppendASCII("browser_action")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698